Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial attempt at help text for SMTP saves #25446

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Jan 15, 2025

For #25109

image

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.59%. Comparing base (6977ec9) to head (b7481b2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25446   +/-   ##
=======================================
  Coverage   63.59%   63.59%           
=======================================
  Files        1619     1619           
  Lines      154939   154939           
  Branches     4038     4038           
=======================================
  Hits        98530    98530           
  Misses      48641    48641           
  Partials     7768     7768           
Flag Coverage Δ
frontend 53.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noahtalerman
Copy link
Member

Thanks Ian! Nice find. Did not know that we already send a test email haha.

Like any other feature request, the plan is to bring this one through the prioritization process and drafting before we merge in your PR (make a change to the product).

We’ll weigh this request at the next feature fest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants