Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace node-sass with sass #25493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sgress454
Copy link
Contributor

The current node-sass dependency in the front end is unmaintained:

image

and has caused some build issues. I've tested the suggested replacement and was able to build the frontend bundle as well as Storybook with no problems.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.59%. Comparing base (51fecdd) to head (56401df).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25493   +/-   ##
=======================================
  Coverage   63.59%   63.59%           
=======================================
  Files        1619     1619           
  Lines      154976   154976           
  Branches     4038     3987   -51     
=======================================
  Hits        98559    98559           
  Misses      48649    48649           
  Partials     7768     7768           
Flag Coverage Δ
frontend 53.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant