Fixes issue verifying Windows CSP profiles that contain ADMX policies. #25528
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25528 +/- ##
=======================================
Coverage 63.59% 63.60%
=======================================
Files 1619 1620 +1
Lines 155002 155038 +36
Branches 3985 3990 +5
=======================================
+ Hits 98580 98614 +34
Misses 48653 48653
- Partials 7769 7771 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # server/mdm/microsoft/profile_verifier.go
# Conflicts: # server/mdm/microsoft/profile_verifier.go
| // ADMX policy elements are not case-sensitive. For example: <enabled/> and <Enabled/> are equivalent | ||
| // For simplicity, we compare everything in lowercase. | ||
| var policy admxPolicy | ||
| err = xml.Unmarshal([]byte(`<admx>`+strings.ToLower(unescaped)+`</admx>`), &policy) |
There was a problem hiding this comment.
Won't unescaped already include the <admx/> tags? Is it intentional to wrap in those <admx/> again here?
There was a problem hiding this comment.
No, unescaped looks like: <enabled/><data id="Item" value="foo"/>
I don't know how to unmarshal it without adding a root XML element.
<admx> is just a random throw-away name. It could be <bozo>
For #24790
Support verifying Windows CSPs with ADMX policies.
https://learn.microsoft.com/en-us/windows/client-management/understanding-admx-backed-policies
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.