Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to handle unsupported devise routes #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jimmynguyc
Copy link

The default devise routes shouldn't be usable. If we don't do this then the default devise routes are accessible directly, and it will not follow the SSO flow.

Also because we're not doing config.omniauth :xxxxxxx in config/devise.rb. It will not include Devise::OmniAuth::UrlHelpers an therefore you'll have problems when you access the default Devise templates that contains omniauth_authorize_path(resource_name, provider)

@namor
Copy link
Member

namor commented Oct 13, 2015

The gem doesn't have devise as a dependency .. any idea of a better solution?
Also we don't assume that default scope is :user
will have to make that a variable somehow

@jimmynguyc
Copy link
Author

Ah you're right .. I thought it was dependent. I mean it's not the concern of this gem already I think if devise is not a dependancy. Maybe just a note. I'll make an update.

As for the scope you're doing it throught activate_sso :user no?

@jimmynguyc
Copy link
Author

Ended up being a huge "note" 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants