[google_maps_flutter] Add marker clustering support - iOS implementation #6186

jokerttu · 2024-02-23T14:36:13Z

This PR introduces support for marker clustering for iOS platform

An example usabe is available in the example application at ./packages/google_maps_flutter/google_maps_flutter_ios/example/ios12 on the page Manage clustering

This is prequel PR for: #4319
and sequel PR for: #6158

Containing only changes to google_maps_flutter_ios package.

Follow up PR will hold the app-facing plugin implementation.

Linked issue: flutter/flutter#26863

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

hellohuanlin

The code looks quite clean. But I feel I don't know enough about clusters to stamp it just yet. Could you also invite the reviewers from your previous PR?

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FLTClusterManagersController.h

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FLTClusterManagersController.m

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapMarkerController.m

hellohuanlin

can you add some unit tests on native side?

packages/google_maps_flutter/google_maps_flutter_ios/ios/google_maps_flutter_ios.podspec

jokerttu · 2024-04-03T12:09:51Z

@hellohuanlin

can you add some unit tests on native side?

Added some native unit tests

hellohuanlin

Thanks for adding those tests. The overall code looks clean.

@cbracken feel free to give it another pass (if you see fit) since you are the new owner. Otherwise I think it's good to land.

...er/google_maps_flutter_ios/example/ios12/ios/RunnerTests/FLTClusterManagersControllerTests.m

...er/google_maps_flutter_ios/example/ios14/ios/RunnerTests/FLTClusterManagersControllerTests.m

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FLTClusterManagersController.h

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FLTClusterManagersController.m

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMarkerUserData.h

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMarkerUtilities.h

packages/google_maps_flutter/google_maps_flutter_ios/ios/google_maps_flutter_ios.podspec

packages/google_maps_flutter/google_maps_flutter_ios/lib/src/google_maps_flutter_ios.dart

jmagman · 2024-05-08T21:13:29Z

@jokerttu is this ready for re-review?

jokerttu · 2024-05-13T09:39:51Z

@jokerttu is this ready for re-review?

@jmagman not yet, this is waiting new release of Google-Maps-iOS-Utils library to have support latest Google Maps SDK versions. See discussion here: #6186 (comment)

stuartmorgan · 2024-05-15T14:41:40Z

FYI I have raised the blocking issue internally with the Google Maps team.

jokerttu · 2024-08-06T18:21:55Z

@stuartmorgan
Fixed the issues mentioned in the review.
Rebased and fixed conflicts with heatmap support.

…n Google-Maps-iOS-Utils

stuartmorgan

Sorry, I missed a couple of things; once those are done this will be good to land.

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapMarkerController.h

packages/google_maps_flutter/google_maps_flutter_ios/lib/src/google_maps_flutter_ios.dart

auto-submit · 2024-08-06T19:39:06Z

auto label is removed for flutter/packages/6186, due to This PR has not met approval requirements for merging. Changes were requested by {stuartmorgan}, please make the needed changes and resubmit this PR.
The PR author is a member of flutter-hackers and needs 0 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

jokerttu · 2024-08-06T19:46:37Z

@stuartmorgan seems like I need separate approval from you before I can add autosubmit label.

stuartmorgan

LGTM. Sorry, I should have pressed the other button last time to avoid that.

…lementation (flutter/packages#6186)

flutter/packages@551bde5...5cc0a01 2024-08-07 [email protected] [ci] Update repository for the release of Flutter 3.24 (flutter/packages#7331) 2024-08-07 [email protected] Roll Flutter (stable) from b0850be to 80c2e84 (1397 revisions) (flutter/packages#7322) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.5 to 4.3.6 (flutter/packages#7330) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.7 to 1.13.12 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7189) 2024-08-07 [email protected] [google_maps_flutter] Marker clustering support (flutter/packages#4319) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.15 to 3.26.0 (flutter/packages#7329) 2024-08-07 [email protected] Manual roll Flutter from 1dd7141 to 0a7f8af (23 revisions) (flutter/packages#7328) 2024-08-06 [email protected] [image_picker_ios] Update image picker UI test query for iOS 18 (flutter/packages#7325) 2024-08-06 [email protected] [google_maps_flutter] Add marker clustering support - iOS implementation (flutter/packages#6186) 2024-08-06 [email protected] [url_launcher] launchUrl always returns true for valid schemes on the web. (flutter/packages#7229) 2024-08-06 [email protected] [google_maps_flutter] Add heatmap support (flutter/packages#3257) 2024-08-06 [email protected] [local_auth] Endorse macOS (flutter/packages#7274) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added p: google_maps_flutter platform-ios labels Feb 23, 2024

jokerttu mentioned this pull request Feb 23, 2024

[google_maps_flutter] Marker clustering support #4319

Merged

11 tasks

jokerttu changed the title ~~[google_maps_flutter_ios] Add marker clustering support~~ [google_maps_flutter] Add marker clustering support - iOS implementation Feb 29, 2024

jokerttu force-pushed the feature/google_maps_flutter_ios_marker_clustering branch 3 times, most recently from cc42eb1 to 0f29034 Compare March 1, 2024 10:19

jokerttu marked this pull request as ready for review March 1, 2024 10:35

jokerttu requested a review from hellohuanlin as a code owner March 1, 2024 10:35

hellohuanlin reviewed Mar 5, 2024

View reviewed changes

hellohuanlin requested a review from stuartmorgan March 5, 2024 20:39

jokerttu force-pushed the feature/google_maps_flutter_ios_marker_clustering branch 2 times, most recently from 00b59e4 to 1669b76 Compare March 7, 2024 12:22

jokerttu requested a review from hellohuanlin March 7, 2024 12:22

hellohuanlin reviewed Mar 9, 2024

View reviewed changes

packages/google_maps_flutter/google_maps_flutter_ios/ios/google_maps_flutter_ios.podspec Outdated Show resolved Hide resolved

jokerttu force-pushed the feature/google_maps_flutter_ios_marker_clustering branch 2 times, most recently from b0e9ada to b4eaeba Compare April 3, 2024 12:09

jokerttu force-pushed the feature/google_maps_flutter_ios_marker_clustering branch from b4eaeba to 2c326e8 Compare April 8, 2024 08:12

jokerttu requested a review from cbracken as a code owner April 8, 2024 08:12

jokerttu requested a review from hellohuanlin April 8, 2024 08:55

hellohuanlin approved these changes Apr 8, 2024

View reviewed changes

stuartmorgan requested changes Apr 24, 2024

View reviewed changes

jokerttu force-pushed the feature/google_maps_flutter_ios_marker_clustering branch 2 times, most recently from e382d51 to 9cc025d Compare April 25, 2024 12:39

stuartmorgan mentioned this pull request May 1, 2024

[google_maps_flutter] Add heatmap support #3257

Merged

11 tasks

stuartmorgan added the triage-ios Should be looked at in iOS triage label Jun 3, 2024

jokerttu force-pushed the feature/google_maps_flutter_ios_marker_clustering branch from 12face8 to 21dc4ef Compare August 6, 2024 18:27

jokerttu added 6 commits August 6, 2024 21:34

[google_maps_flutter_ios] Add support for cluster markering

22cc736

[google_maps_flutter_ios] Quality improvements to clustering support

e3ca225

[google_maps_flutter_ios] Update swift_version to match the version i…

f91197b

…n Google-Maps-iOS-Utils

[google_maps_flutter_ios] Fix clustering tests

77c78c1

[google_maps_flutter_ios] Rename new classes to use FGM prefix

b78f118

[google_maps_flutter_ios] improve obj-c documentation

b25170b

jokerttu force-pushed the feature/google_maps_flutter_ios_marker_clustering branch from 21dc4ef to b25170b Compare August 6, 2024 18:34

jokerttu requested a review from stuartmorgan August 6, 2024 18:34

stuartmorgan requested changes Aug 6, 2024

View reviewed changes

jokerttu added 2 commits August 6, 2024 22:15

[google_maps_flutter_ios] revert obj-c import ordering changes

7c2cdf9

[google_maps_flutter_ios] revert unnecessary changes

bc4eb1b

jokerttu requested a review from stuartmorgan August 6, 2024 19:31

jokerttu added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

stuartmorgan approved these changes Aug 6, 2024

View reviewed changes

stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

auto-submit bot merged commit ec92d7d into flutter:main Aug 6, 2024
76 checks passed

engine-flutter-autoroll mentioned this pull request Aug 7, 2024

Roll Packages from 551bde53f6ea to f330ca3c2fa3 (11 revisions) flutter/flutter#153025

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2024

ec92d7d [google_maps_flutter] Add marker clustering support - iOS imp…

df7c454

…lementation (flutter/packages#6186)

engine-flutter-autoroll mentioned this pull request Aug 7, 2024

Roll Packages from 551bde53f6ea to 5cc0a0160194 (12 revisions) flutter/flutter#153040

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2024

ec92d7d [google_maps_flutter] Add marker clustering support - iOS imp…

912a478

…lementation (flutter/packages#6186)

jokerttu deleted the feature/google_maps_flutter_ios_marker_clustering branch September 9, 2024 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[google_maps_flutter] Add marker clustering support - iOS implementation #6186

[google_maps_flutter] Add marker clustering support - iOS implementation #6186

jokerttu commented Feb 23, 2024 •

edited

Loading

hellohuanlin left a comment

hellohuanlin left a comment

jokerttu commented Apr 3, 2024 •

edited

Loading

hellohuanlin left a comment •

edited

Loading

jmagman commented May 8, 2024

jokerttu commented May 13, 2024

stuartmorgan commented May 15, 2024

jokerttu commented Aug 6, 2024

stuartmorgan left a comment

auto-submit bot commented Aug 6, 2024

jokerttu commented Aug 6, 2024

stuartmorgan left a comment

[google_maps_flutter] Add marker clustering support - iOS implementation #6186

[google_maps_flutter] Add marker clustering support - iOS implementation #6186

Conversation

jokerttu commented Feb 23, 2024 • edited Loading

Pre-launch Checklist

hellohuanlin left a comment

Choose a reason for hiding this comment

hellohuanlin left a comment

Choose a reason for hiding this comment

jokerttu commented Apr 3, 2024 • edited Loading

hellohuanlin left a comment • edited Loading

Choose a reason for hiding this comment

jmagman commented May 8, 2024

jokerttu commented May 13, 2024

stuartmorgan commented May 15, 2024

jokerttu commented Aug 6, 2024

stuartmorgan left a comment

Choose a reason for hiding this comment

auto-submit bot commented Aug 6, 2024

jokerttu commented Aug 6, 2024

stuartmorgan left a comment

Choose a reason for hiding this comment

jokerttu commented Feb 23, 2024 •

edited

Loading

jokerttu commented Apr 3, 2024 •

edited

Loading

hellohuanlin left a comment •

edited

Loading