Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect SwiftPM plugin migration step #11029

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Aug 8, 2024

This was caught by @brianquinlan while migrating the cupertino_http plugin.

Review URL: https://flutter-docs-prod--pr11029-brian-feedback-9wffzaxo.web.app/packages-and-plugins/swift-package-manager/for-plugin-authors#how-to-add-swift-package-manager-support-to-an-existing-flutter-plugin

Part of: dart-lang/http#1276 (comment)

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 78d0fef):

https://flutter-docs-prod--pr11029-brian-feedback-9wffzaxo.web.app

@loic-sharma loic-sharma merged commit 1224988 into flutter:main Aug 9, 2024
9 checks passed
@loic-sharma loic-sharma deleted the brian_feedback branch August 9, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants