-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Federated plugin structure #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renefloor
changed the title
Feature/plugin federation
Migrate to Federated plugin structure
May 6, 2024
renefloor
force-pushed
the
feature/plugin-federation
branch
3 times, most recently
from
May 6, 2024 11:43
3dfe0e0
to
8923aa1
Compare
Signed-off-by: Rene Floor <[email protected]>
Signed-off-by: Rene Floor <[email protected]>
Signed-off-by: Rene Floor <[email protected]>
Signed-off-by: Rene Floor <[email protected]>
Signed-off-by: Rene Floor <[email protected]>
Signed-off-by: Rene Floor <[email protected]>
Signed-off-by: Rene Floor <[email protected]>
Signed-off-by: Rene Floor <[email protected]>
Signed-off-by: Rene Floor <[email protected]>
Signed-off-by: Rene Floor <[email protected]>
Signed-off-by: Rene Floor <[email protected]>
renefloor
force-pushed
the
feature/plugin-federation
branch
from
May 6, 2024 13:00
916fe99
to
55aadf6
Compare
renefloor
commented
May 6, 2024
Signed-off-by: Rene Floor <[email protected]>
mvolpato
reviewed
May 6, 2024
mvolpato
reviewed
May 8, 2024
packages/platform_maps_flutter_apple/lib/src/apple_maps_widget.dart
Outdated
Show resolved
Hide resolved
mvolpato
reviewed
May 8, 2024
packages/platform_maps_flutter_google_android/lib/src/google_map_original.dart
Show resolved
Hide resolved
mvolpato
reviewed
May 8, 2024
packages/platform_maps_flutter_google_android/lib/src/google_maps_widget.dart
Outdated
Show resolved
Hide resolved
mvolpato
reviewed
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. I run the example on iOS and it works well.
mvolpato
previously approved these changes
May 8, 2024
jogboms
reviewed
May 13, 2024
jogboms
previously approved these changes
May 13, 2024
packages/platform_maps_flutter_apple/lib/src/apple_maps_platform_controller.dart
Outdated
Show resolved
Hide resolved
packages/platform_maps_flutter_google_android/lib/src/google_maps_platform_controller.dart
Outdated
Show resolved
Hide resolved
renefloor
force-pushed
the
feature/plugin-federation
branch
from
May 17, 2024 07:39
72a57d8
to
d1148c6
Compare
Co-authored-by: Jan van den Berg <[email protected]> Signed-off-by: Rene Floor <[email protected]>
Co-authored-by: Michele Volpato <[email protected]> Signed-off-by: Rene Floor <[email protected]>
Signed-off-by: Rene Floor <[email protected]>
renefloor
force-pushed
the
feature/plugin-federation
branch
from
May 17, 2024 07:43
d1148c6
to
6a2ba97
Compare
Signed-off-by: Rene Floor <[email protected]>
renefloor
force-pushed
the
feature/plugin-federation
branch
from
May 24, 2024 07:51
6677707
to
13ca692
Compare
jogboms
approved these changes
May 24, 2024
mvolpato
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the plugin to a federated plugin setup.
This allows devs to use a different type of platform map, for example if they don't like Google maps on Android but want to use something else, but more importantly, this removes the dependency on GoogleMaps from the iOS app.
Still to do
Issue #65
Pre-launch Checklist
///
).