Add labels and annotations to with_overrides #6145
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pryce-turner <[email protected]>
Code Review Agent Run Status
|
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6145 +/- ##
===========================================
+ Coverage 37.01% 55.13% +18.11%
===========================================
Files 1317 99 -1218
Lines 132523 5978 -126545
===========================================
- Hits 49060 3296 -45764
+ Misses 79217 2490 -76727
+ Partials 4246 192 -4054
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thomasjpfan
reviewed
Jan 13, 2025
There was a problem hiding this comment.
To generate the flyteidl files from a proto change:
cd flyteidl
make generateThen build flyte binary:
https://docs.flyte.org/en/latest/community/contribute/contribute_code.html#requirements
Comment on lines
204
to
206
| Labels labels = 10; | ||
|
|
||
| Annotations annotations = 11; |
There was a problem hiding this comment.
Suggested change
| Labels labels = 10; | |
| Annotations annotations = 11; | |
| flyteidl.admin.Labels labels = 10; | |
| flyteidl.admin.Annotations annotations = 11; |
There was a problem hiding this comment.
How come RetryStrategy can be inferred from literals but Labels and Annotations can't be inferred from common?
Signed-off-by: pryce-turner <[email protected]>
Code Review Agent Run Status
|
Signed-off-by: pryce-turner <[email protected]>
Code Review Agent Run Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Improvement to allow setting labels and annotations dynamically at run time for things like cost allocation
What changes were proposed in this pull request?
Adds labels and annotations to with_overrides()
How was this patch tested?
TBD
Check all the applicable boxes
Related PRs
flyteorg/flytekit#3037
Docs link
TBD