-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIEH-1440: Package Record - Title List Accordion - Improve Visibility of Search Within/Filter/Sort options. #1757
Conversation
… of Search Within/Filter/Sort options.
32bdf35
to
bf00856
Compare
Quality Gate passedIssues Measures |
|
||
// focus on the default option | ||
setTimeout(() => { | ||
document.querySelector(`[aria-labelledby="${labelId}"] input[tabindex="0"]`)?.focus(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use autoFocus={isChecked}
on <RadioButton>
instead of this call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to move the focus after hitting the clear icon, this will happen on page update, and autoFocus
is only for page mounting.
Description
UI changes:
Functionality changes:
Before:
After:
Issues
UIEH-1440
Approach
search-section
for a search box, search options, and Actions button;hasAccordion
prop is used.Screencasts:
2025-01-09_11h10_55.mp4
Approach
TODOS and Open Questions
Learning
Screenshots