Revert "Eventyay Common: Create an event dashboard" #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3ddbd09.
Reviewer's Guide by SourceryThis PR reverts the changes introduced in #484, which implemented an event dashboard. The revert removes the dashboard view and associated logic, including widgets, permissions checks, and context processors. It also simplifies the base template and removes styling related to the dashboard. Class diagram showing removed EventIndexView and related componentsclassDiagram
class EventIndexView {
-template_name: str
-rearrange(widgets)
-_get_user_permissions()
-_collect_dashboard_widgets()
-_filter_log_entries()
-_check_event_statuses()
+get_context_data()
}
class Event {
+talk_schedule_url
+talk_session_url
+talk_speaker_url
-talk_dashboard_url
-talk_settings_url
}
note for Event "Removed dashboard and settings URLs"
note for EventIndexView "Entire class removed"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @mariobehling - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+1138
to
1139
| url = urljoin(talk_host, f"{self.slug}/schedule") | ||
| return url |
There was a problem hiding this comment.
suggestion (code-quality): Inline variable that is immediately returned (inline-immediately-returned-variable)
Suggested change
| url = urljoin(talk_host, f"{self.slug}/schedule") | |
| return url | |
| return urljoin(talk_host, f"{self.slug}/schedule") |
Comment on lines
+1144
to
1145
| url = urljoin(talk_host, f"{self.slug}/talk") | ||
| return url |
There was a problem hiding this comment.
suggestion (code-quality): Inline variable that is immediately returned (inline-immediately-returned-variable)
Suggested change
| url = urljoin(talk_host, f"{self.slug}/talk") | |
| return url | |
| return urljoin(talk_host, f"{self.slug}/talk") |
Comment on lines
+1150
to
1151
| url = urljoin(talk_host, f"{self.slug}/speaker") | ||
| return url |
There was a problem hiding this comment.
suggestion (code-quality): Inline variable that is immediately returned (inline-immediately-returned-variable)
Suggested change
| url = urljoin(talk_host, f"{self.slug}/speaker") | |
| return url | |
| return urljoin(talk_host, f"{self.slug}/speaker") |
| try: | ||
| url = resolve(request.path_info) | ||
| except Resolver404: | ||
| return {} | ||
|
|
||
| if not request.path.startswith(f"{get_script_prefix()}common"): | ||
| if not request.path.startswith(get_script_prefix() + 'common'): |
There was a problem hiding this comment.
suggestion (code-quality): Use f-string instead of string concatenation (use-fstring-for-concatenation)
Suggested change
| if not request.path.startswith(get_script_prefix() + 'common'): | |
| if not request.path.startswith(f'{get_script_prefix()}common'): |
Comment on lines
+7
to
+8
| 'ticket_component': settings.SITE_URL + '/control', | ||
| 'talk_component': settings.TALK_HOSTNAME + '/orga', |
There was a problem hiding this comment.
suggestion (code-quality): Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)
Suggested change
| 'ticket_component': settings.SITE_URL + '/control', | |
| 'talk_component': settings.TALK_HOSTNAME + '/orga', | |
| 'ticket_component': f'{settings.SITE_URL}/control', | |
| 'talk_component': f'{settings.TALK_HOSTNAME}/orga', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #484
Summary by Sourcery
Remove the event dashboard.