Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated release version to bionic for meilix iso- (Solves -#332) #333

Closed
wants to merge 3 commits into from

Conversation

pranav1698
Copy link

@pranav1698 pranav1698 commented Nov 16, 2018

Short description

The release is updated to bionic from xenial
The build passed for my fork,
Link for the releases: https://travis-ci.org/pranav1698/meilix/builds/456026550
The latest release for my fork: https://github.com/pranav1698/meilix/releases/tag/untagged-08b773a3e370def55b2b

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

Fixes #332

@meets2tarun
Copy link
Member

hi @pranav1698 Did you checked the released iso?

@pranav1698
Copy link
Author

Even though the build is passing and we are getting a released ISO:
I checked the ISO for defects, it was showing defects in two files also the ISO was not working as expected
I checked for xenial too but their were no defects in that ISO
Even if we change the release to bionic travis is running on xenial, I think that may be the cause of the defects in the iso
Also even after updating the dist to bionic in .tarvis.yml it was switching to precise(maybe it is default) causing the build to because of naturally package not found error more in formation can be found here: https://docs.travis-ci.com/user/reference/overview/
So basically travis is not supporting bionic for the image formation
@meets2tarun @tabesin @abishekvashok what do you think?

@tabesin
Copy link
Member

tabesin commented Nov 17, 2018

"I checked the ISO for defects, it was showing defects in two files also the ISO was not working as expected"

What precisely?

@pranav1698
Copy link
Author

pranav1698 commented Nov 17, 2018

screenshot at 20-21-40

This was the screen that I got it was not happening for xenial

@pranav1698
Copy link
Author

Even though openbox is installed in iso as default wm, it asks for window manager, after choosing openbox it gives a black screen

@abishekvashok
Copy link
Member

If you think Travis doesn't support us to go to bionic, then we can containerize things.

@abishekvashok
Copy link
Member

@tabesin
Copy link
Member

tabesin commented Nov 24, 2018

The asking for wm issue is found online as a common request of users. Pls check.

@pranav1698
Copy link
Author

I think I have to check all the things from the starting and hence I am closing the pr for now

@pranav1698
Copy link
Author

Thanks for the help @abishekvashok and @tabesin! I will look onto it and soon open a new pr

@pranav1698 pranav1698 deleted the update-release branch November 28, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants