Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add static json file for console services and return them by an API #1377

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

harsh-jindal
Copy link
Member

Fixes #1368

Changes: Return console services.

Screenshots for the change:
Screenshot 2019-08-11 at 12 49 26 AM

@harsh-jindal
Copy link
Member Author

@akshatnitd @fragm3 Please check if this is the right way we are suppose to display the console services. This is still WIP. We should display all skills present in conf/os_skills/system/en Right?

Copy link
Member

@akshatnitd akshatnitd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each skill object should have meta data similar to other normal skills, so that we can represent it on the UI

@Orbiter
Copy link
Contributor

Orbiter commented Aug 11, 2019

I'm unsure if we should do this #1368 (comment)

@harsh-jindal
Copy link
Member Author

@akshatnitd A normal skill object has:

  1. Name
  2. Author(What shall be present here?)
  3. Rating (cannot be displayed)
  4. Description(What shall be the description? some skills are group_messages shall those be present on the cms?)
  5. Skill Details
    a. Category (What shall be the category?)
    b. Language (English)
    c. Updated On(cannot be displayed)
    d. Languages supported (English)
    e. Flag as inappropriate (cannot be displayed)
    f. Content rating (4+)
  6. Rating (Cannot be displayed)
  7. Skill Usage (Cannot be displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add static json file for console services and return them by an API
4 participants