Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more options to profcile render #1600

Merged

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Nov 26, 2024

This PR increases the flexibility to render procfile according to needs.

@blaggacao blaggacao force-pushed the feat/add-direct-config-module-calling branch from d575d84 to cf3eec6 Compare November 26, 2024 12:22
blaggacao added a commit to blaggacao/frappe that referenced this pull request Nov 26, 2024
bench/config/procfile.py Outdated Show resolved Hide resolved
@blaggacao blaggacao force-pushed the feat/add-direct-config-module-calling branch from 95182c8 to 786b63d Compare November 27, 2024 11:17
@blaggacao blaggacao force-pushed the feat/add-direct-config-module-calling branch from 786b63d to f643bff Compare November 27, 2024 11:18
Copy link
Member

@akhilnarang akhilnarang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good functionality wise, but should move to use the existing click commands that we have

@blaggacao blaggacao force-pushed the feat/add-direct-config-module-calling branch from f643bff to ac08ec6 Compare November 27, 2024 15:16
@blaggacao blaggacao changed the title feat: add direct config module calling feat: add more options to profcile render Nov 27, 2024
@akhilnarang akhilnarang merged commit a9a6ae9 into frappe:develop Nov 28, 2024
13 checks passed
Copy link

🎉 This PR is included in version 5.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blaggacao blaggacao deleted the feat/add-direct-config-module-calling branch November 28, 2024 07:47
blaggacao added a commit to frappe/frappe that referenced this pull request Nov 28, 2024
* ci: chore revert using branched bench

merge after is released: frappe/bench#1600

* ci: name downstream job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants