Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out communications coming from Notifications in on_communication_u… #1663

Open
wants to merge 1 commit into
base: version-14
Choose a base branch
from
Open

Filter out communications coming from Notifications in on_communication_u… #1663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,9 @@ def apply_sla(self):
# is an external dependency. Refer `communication.py` of Frappe framework for more.
# Since this is called from communication itself, `c` is the communication doc.
def on_communication_update(self, c):
# ignore frappe notifications as they also trigger on_communication_update
if c.sender_full_name=="Notifications":
return
if c.sent_or_received == "Sent":
# If communication is outgoing, then it is a reply from agent.
self.status = "Replied"
Expand Down