Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix all the broken links and add a Link linter #28

Merged
merged 4 commits into from
Jul 14, 2024

Conversation

olivierodo
Copy link
Contributor

@olivierodo olivierodo commented Jun 26, 2024

Hi,
First of all, thank you for the fantastic work on this ebook.
As I saw there is a 800+ link to external website in this ebook and some of them are broken...

Then allow me to propose a Github Action that will check the health of each link.

While running it on my fork, I found around 50 links that was broken, see report:

image

I feel all of them, feel free to review 😄.

The github action use for to link check: https://github.com/marketplace/actions/404-links


⚠️ One important thing: Since you are deploying the ebook on github page using the traditional way... Activating the github action might the deployement of the page.. (I'm not sure at all about it)
But a good thing would be to try to configure and deploy on github page using github action:

* Fix link "Health Check Response Format for HTTP APIs"

* Fix link about "Duck Typing in JavaScript and TypeScript"

* Remove dead link: https://nodejs.org/en/docs/meta/topics/dependencies/

* small rephrase (en)

* Replacing link: "Get Ready For ESM - Sindresorhus"

* Replace dead link: "Why Most Unit Testing is Waste"

* Replace dead link "it's not necessarily the best choice" ( F*** express)

* Replace dead link: "Why Adonis.js ?"

* Replace dead link : "the success of Fastify" (snyk)

* Fix link "Supercharge Your Node.js With Rust"

* Replace link "The package.json guide"

* Fix dead link "pnpm workspace"

* Fix link "Node.js debugging best practices"

* Fix youtube redis link

* Remove dead. link "badJS"

* Fix misspell on  link

* Fix misspell on link

* rephase

* Create .404-links.yml to conflg the link linter

* CI: fix dead link on the french version

* CI: Fix last dead link 😮‍💨
@fraxken
Copy link
Owner

fraxken commented Jul 14, 2024

Thanks @olivierodo, that's perfect! I was also thinking about adding an Action like that because each time I fix a ton of broken links

@fraxken fraxken merged commit 28e5fa6 into fraxken:main Jul 14, 2024
1 check failed
@fraxken
Copy link
Owner

fraxken commented Jul 14, 2024

@allcontributors please add @olivierodo for code

Copy link
Contributor

@fraxken

I've put up a pull request to add @olivierodo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants