Skip to content

Commit

Permalink
Code cleanup: Remove unneeded #imports, empty methods, declare id ret…
Browse files Browse the repository at this point in the history
…urn type when left out, commit irrelevant whitespace flagged as change.
  • Loading branch information
andreberg committed Mar 24, 2010
1 parent b6272c0 commit 4832f3b
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 15 deletions.
4 changes: 2 additions & 2 deletions PBCommitList.m
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ - (NSDragOperation)draggingSourceOperationMaskForLocal:(BOOL) local
- (void)keyDown:(NSEvent *)event
{
NSString* character = [event charactersIgnoringModifiers];

// Pass on command-shift up/down to the responder. We want the splitview to capture this.
if ([event modifierFlags] & NSShiftKeyMask && [event modifierFlags] & NSCommandKeyMask && ([event keyCode] == 0x7E || [event keyCode] == 0x7D)) {
[self.nextResponder keyDown:event];
return;
}

if ([character isEqualToString:@" "]) {
if (controller.selectedCommitDetailsIndex == 0) {
if ([event modifierFlags] & NSShiftKeyMask)
Expand Down
4 changes: 2 additions & 2 deletions PBGitConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
NSString *repositoryPath;
}
@property (copy) NSString *repositoryPath;
- init;
- initWithRepositoryPath:(NSString *)path;
- (id) init;
- (id) initWithRepositoryPath:(NSString *)path;
@end
4 changes: 2 additions & 2 deletions PBGitConfig.m
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
@implementation PBGitConfig
@synthesize repositoryPath;

- init
- (id) init
{
repositoryPath = nil;
return self;
}

- initWithRepositoryPath:(NSString *)path
- (id) initWithRepositoryPath:(NSString *)path
{
repositoryPath = path;
return self;
Expand Down
2 changes: 0 additions & 2 deletions PBGitRepository.m
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,6 @@ - (void) addRef: (PBGitRef *) ref fromParameters: (NSArray *) components
- (void) reloadRefs
{
_headRef = nil;
BOOL ret = NO;

refs = [NSMutableDictionary dictionary];
NSMutableArray *oldBranches = [branches mutableCopy];

Expand Down
2 changes: 1 addition & 1 deletion PBGitSidebarController.m
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ - (id)initWithRepository:(PBGitRepository *)theRepository superController:(PBGit
- (void)awakeFromNib
{
[super awakeFromNib];
window.contentView = self.view;
window.contentView = [self view];
[self populateList];

historyViewController = [[PBGitHistoryController alloc] initWithRepository:repository superController:superController];
Expand Down
1 change: 0 additions & 1 deletion PBRefController.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#import "PBRefController.h"
#import "PBGitRevisionCell.h"
#import "PBRefMenuItem.h"
#import "KBPopUpToolbarItem.h"
#import "PBCreateBranchSheet.h"
#import "PBCreateTagSheet.h"
#import "PBGitDefaults.h"
Expand Down
1 change: 0 additions & 1 deletion PBViewController.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,4 @@
- (NSResponder *)firstResponder;
- (IBAction) refresh:(id)sender;

- (IBAction) refresh:(id)sender;
@end
4 changes: 0 additions & 4 deletions PBViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,6 @@ - (void) updateView
{
}

- (IBAction) refresh: sender
{
}

- (NSResponder *)firstResponder;
{
return nil;
Expand Down

0 comments on commit 4832f3b

Please sign in to comment.