fix: IMEI/IMEISV validation and test cases #30
+78
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy89923
reviewed
Jan 9, 2025
Note
|
andy89923
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Hi @williamlin0518 ,
Overall, it's LGTM!
Try to replace NAS package in free5gc and test the functionalities.
Please report the result here, thanks.
tim-ywliu
reviewed
Jan 13, 2025
| } else { | ||
| if len(digitStr) != 16 { | ||
| return "", fmt.Errorf("invalid IMEISV length: expected 16 digits, got %d", len(digitStr)) | ||
| } |
There was a problem hiding this comment.
why not validate IMEISV here?
There was a problem hiding this comment.
IMEISV contains the first 14 digits of IMEI (TAC+SNR) and 2 digits of Software Version Number (SVN).
There is no Checksum or algorithm applied to IMEISV, so I think he only checks the length of the digits for now.
TS23.003
|
I have tested the NAS package integration by: Running full test suite comparison:
Results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is related to issue #624