Update outdated dependencies #248
Conversation
upstream merge
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| @@ -90,6 +92,8 @@ draw2d.shape.basic.Label = draw2d.SetFigure.extend( | |||
| padding: this.setPadding, | |||
| // @attr {Boolean} bold indicator if bold text should be used*/ | |||
| bold: this.setBold, | |||
|
|
|||
| textAlign: this.textAlign, | |||
There was a problem hiding this comment.
do not match the common pattern in draw2d with get#### and set####
| @@ -237,8 +242,35 @@ draw2d.shape.basic.Label = draw2d.SetFigure.extend( | |||
| * @returns {Number} | |||
| * @since 4.0.1 | |||
| */ | |||
| getFontSize: function () { | |||
There was a problem hiding this comment.
getFontSize is missing in the branch
|
|
||
| this.start = new draw2d.geo.Point(30, 30) | ||
| this.end = new draw2d.geo.Point(100, 100) | ||
|
|
||
| this.glowColor = new draw2d.util.Color("#3f72bf") | ||
| this.glowStrokeSize = this.stroke * 2.5; |
There was a problem hiding this comment.
is it maybe a good idea to use a constant for the glowStrokeSize factor of 2.5? On a different code you has changed it from 2.5 to 1.5 and here is still the factor 2.5
|
Hi @freegroup, thanks again for this library. I've been using it for close to 10 years now. I created my own fork recently and mistakenly created a PR back to yours that included some edits from others' forks as well. You can ignore this, but it would be great to see a new release as it looks like the new |
|
thanks...if your pull request is working I can integrate them...happy to see bugfixes :-) |
|
I would suggest starting with existing PR #247 that updates to |
No description provided.