Fix mysql connection string #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: DasSkelett <[email protected]> Co-authored-by: GoliathLabs <[email protected]>
GoliathLabs
approved these changes
Nov 18, 2021
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of Place1#135 fixing issue Place1#134
It has been slightly changed from @nox-404's solution, using
url.Hostinstead ofurl.Hostname()andurl.Port()joined separately, as the second one would cause issues with raw IPv6 addresses (whichurl.Hostname()returns without enclosing brackets).url.Hostreturns host and port already combined, with brackets for IPv6 addresses.