Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playing cards unicode symbols added for string representation #5

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Zhigal
Copy link

@Zhigal Zhigal commented Nov 25, 2021

No description provided.

Verified

This commit was signed with the committer’s verified signature.
adamperkowski Adam Perkowski
@fschlatt
Copy link
Owner

fschlatt commented Nov 27, 2021

Hey @Zhigal , thanks for the PR. I didn't know those unicode cards exist. They're pretty cool. Unfortunately, there are a couple of issues. Mainly, the unicode characters don't always get rendered the same way and on this could lead to issues on some systems. I would prefer an option for the ascii renderer to use the unicode cards or letters. Second, the PR currently does not pass the tests for the ascii render mode because it they still expect the old card representation. Finally, this representation breaks the webserver html render mode because it uses the string representation of a card to determine the SVG card to use. If you have the time, it would be awesome if you could integrate those changes and resubmit the PR.

@Zhigal
Copy link
Author

Zhigal commented Nov 27, 2021

Thanks for your answer @fschlatt.
I found those unicode symbols recently and decided to contribute into your repo because I use it for my project.
I made some more changes according to your comments, could you check my PR ones again please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants