-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add license expression and icon to template spec #3715
Conversation
86284f3
to
6ec6455
Compare
what's the status? |
I need to figure out how to actually pack files with paket.template. Can't seem to figure it out :/ |
Can we go on here? These nuget deprecation hints are annoying. |
@CaptnCodr you can also put the license expression in your project file and pack with |
@baronfel How about the deprecated "iconUrl"? |
@CaptnCodr https://docs.microsoft.com/en-us/dotnet/core/tools/csproj#packageicon this help doc describes what properties you'd use to set an image, along with a number of others. note that nuget now wants you to embed the icon instead of pointing to an external resource. |
This one should be easy enough, I just kind of gave up on some of the integration tests largely because...I couldn't write a proper paket.template file :/ |
Yes, I see. But we only use the paket.template to generate our nuget packages. |
I think we'd all be happy to take a PR that only does each one at a time. |
|
Ah yes. |
My attempt at #3710, but minus the deprecation parts