Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add license expression and icon to template spec #3715

Closed
wants to merge 1 commit into from

Conversation

cartermp
Copy link
Contributor

My attempt at #3710, but minus the deprecation parts

@cartermp cartermp changed the title Add license expression and icon to template spec [WIP] Add license expression and icon to template spec Nov 12, 2019
@forki
Copy link
Member

forki commented Nov 15, 2019

what's the status?

@cartermp
Copy link
Contributor Author

I need to figure out how to actually pack files with paket.template. Can't seem to figure it out :/

@CaptnCodr
Copy link
Member

Can we go on here? These nuget deprecation hints are annoying.

@baronfel
Copy link
Contributor

baronfel commented Nov 5, 2020

@CaptnCodr you can also put the license expression in your project file and pack with dotnet pack these days, you don't need to use paket.template.

@CaptnCodr
Copy link
Member

@baronfel How about the deprecated "iconUrl"?

@baronfel
Copy link
Contributor

baronfel commented Nov 5, 2020

@CaptnCodr https://docs.microsoft.com/en-us/dotnet/core/tools/csproj#packageicon this help doc describes what properties you'd use to set an image, along with a number of others. note that nuget now wants you to embed the icon instead of pointing to an external resource.

@cartermp
Copy link
Contributor Author

cartermp commented Nov 5, 2020

This one should be easy enough, I just kind of gave up on some of the integration tests largely because...I couldn't write a proper paket.template file :/

@CaptnCodr
Copy link
Member

CaptnCodr commented Nov 5, 2020

Yes, I see. But we only use the paket.template to generate our nuget packages.
But why isn't it implemented like "license" which is the reaction of the deprecation of "licenseUrl" so how about to go on here and you have one PR from the list and an issue from the other? 😄

@cartermp
Copy link
Contributor Author

cartermp commented Nov 5, 2020

I think we'd all be happy to take a PR that only does each one at a time.

@cartermp
Copy link
Contributor Author

cartermp commented Nov 5, 2020

license is also added as per here: #3824

@CaptnCodr
Copy link
Member

Ah yes.

@cartermp cartermp closed this Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants