Skip to content

Commit

Permalink
use correct ItemPT table in Challenge mode
Browse files Browse the repository at this point in the history
  • Loading branch information
fuzziqersoftware committed Oct 20, 2023
1 parent bf346d3 commit 27734a6
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
- Make UI strings localizable (e.g. entries in menus, welcome message, etc.)
- Figure out what causes the corruption message on PC proxy sessions and fix it
- Enable item tracking in battle/challenge games (everything should already be set up for it to work)
- Use challenge mode rare tables in challenge mode games (also, apparently it always uses Viridia? verify this)
- Rewrite REL-based parsers so they don't assume any fixed offsets

## Episode 3
Expand Down
2 changes: 1 addition & 1 deletion src/CommonItemSet.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const CommonItemSet::Table<true>& CommonItemSet::get_table(
((mode == GameMode::CHALLENGE) ? "c" : ""),
((episode == Episode::EP2) ? "l" : ""),
tolower(abbreviation_for_difficulty(difficulty)),
secid);
(mode == GameMode::CHALLENGE) ? 0 : secid);
auto data = this->gsl.get(filename);
if (data.second < sizeof(Table<true>)) {
throw runtime_error(string_printf(
Expand Down
2 changes: 1 addition & 1 deletion src/Lobby.cc
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ void Lobby::create_item_creator() {
} else if (this->base_version == GameVersion::GC || this->base_version == GameVersion::XB) {
rare_item_set = s->rare_item_sets.at("default-v3");
} else {
// TODO: SHould there be a separate table for V1 eventually?
// TODO: Should there be a separate table for V1 eventually?
rare_item_set = s->rare_item_sets.at("default-v2");
}
this->item_creator.reset(new ItemCreator(
Expand Down

0 comments on commit 27734a6

Please sign in to comment.