stop mangling the environments #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egede
previously approved these changes
Dec 11, 2023
ganga/GangaCore/Utility/Shell.py
Outdated
Comment on lines
119
to
123
| self.env = dict(os.environ) | ||
| self.env = os.environ | ||
| execute('source {0} {1}'.format(setup, " ".join(setup_args)), shell=True, env=self.env, update_env=True) | ||
|
|
||
| else: | ||
| # bug #44334: Ganga/Utility/Shell.py does not save environ | ||
| env = dict(os.environ) | ||
| self.env = expand_vars(env) | ||
| self.env = os.environ |
There was a problem hiding this comment.
Seems like the self.env = os.environ can just be put up before the if clause and then just have the execute part inside the if clause.
egede
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the enviroment as the
os._Environtype which can cope with the more complex environments of newer bash shells - in particular multiline functions.