Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed error caused by change to ExtRepOfObj #64

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fixed error caused by change to ExtRepOfObj #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# CHANGES to the 'groupoids' package

## Version 1.75 for GAP 4.13.1 (23/09/24)
* (23/09/24) fix error caused re immutable ExtRepOfObj by GAP pull #5808

## Version 1.74 for GAP 4.12.2 (09/02/23)
* (23/01/24) avoid trivial function wrappers; correct email address

Expand Down
4 changes: 2 additions & 2 deletions PackageInfo.g
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ SetPackageInfo( rec(

PackageName := "groupoids",
Subtitle := "Calculations with finite groupoids and their homomorphisms",
Version := "1.74",
Date := "04/04/2024", # dd/mm/yyyy format
Version := "1.75",
Date := "23/09/2024", # dd/mm/yyyy format
License := "GPL-2.0-or-later",

Persons := [
Expand Down
8 changes: 4 additions & 4 deletions lib/grpgraph.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,7 +1124,7 @@ function( fpa, w )
gg := GraphOfGroupsRewritingSystem( fpa );
dig := DigraphOfGraphOfGroups( gg );
verts := dig!.vertices;
ew := ExtRepOfObj( w );
ew := ShallowCopy( ExtRepOfObj( w ) );
Info( InfoGroupoids, 2, "ew = ", ew );
if ( ew = [ ] ) then
return One( fpa );
Expand Down Expand Up @@ -1190,7 +1190,7 @@ function( fpa, w )
rw := idff;
for j in [1..len] do
k := j+j-1;
e := ExtRepOfObj( wrgw[k] );
e := ShallowCopy( ExtRepOfObj( wrgw[k] ) );
if ( p=2 ) then
for i in [1..(Length(e)/2)] do
e[i+i-1] := e[i+i-1]+ng1;
Expand Down Expand Up @@ -1291,7 +1291,7 @@ function( hnn, w )
Info( InfoGroupoids, 2, "graph of groups has left transversals" );
Info( InfoGroupoids, 2, LeftTransversalsOfGraphOfGroups( gg ) );
v := dig!.vertices[1];
ew := ExtRepOfObj( w );
ew := ShallowCopy( ExtRepOfObj( w ) );
if ( ew = [ ] ) then
return One( hnn );
fi;
Expand Down Expand Up @@ -1354,7 +1354,7 @@ function( hnn, w )
rw := idff;
for j in [1..len] do
k := j+j-1;
e := ExtRepOfObj( wrgw[k] );
e := ShallowCopy( ExtRepOfObj( wrgw[k] ) );
rw := rw*ObjByExtRep( famff, e );
if ( j < len ) then
if ( wrgw[k+1] = 1 ) then
Expand Down
Loading