Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mandarins (WIP) #179

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Implement mandarins (WIP) #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0b2296b
WIP: mandarins
ssiccha Jan 10, 2022
7bf239d
Store mandarins and their SLPs
ssiccha Jan 26, 2022
ef0ff90
WIP mandarin SLPs
ssiccha Feb 21, 2022
33f785f
Var names and info levels
ssiccha Feb 23, 2022
b91d094
Fine tune Imprimitive for permutation groups
ssiccha Feb 23, 2022
e07a4ee
Fix typo
ssiccha Feb 23, 2022
e17882a
Fine tune mandarins
ssiccha Feb 24, 2022
4bc778c
Mandarin docs
ssiccha Feb 24, 2022
89de579
Mandarins remove unused code
ssiccha Feb 24, 2022
582f330
DEBUG COMMIT
ssiccha Feb 22, 2022
ad713a2
DEBUG Mandarins
ssiccha Feb 23, 2022
75fddb1
DEBUG ImmVer and BalBLocks
ssiccha Feb 23, 2022
59e09ba
DEBUG reduce info levels
ssiccha Feb 23, 2022
11b833e
DEBUG constants
ssiccha Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gap/base/kernel.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ InstallGlobalFunction( ImmediateVerification,
fi;
if verified = true then return true; fi;
# Now, verified = false.
Print("Immediate verification: found extra kernel element(s)!\n");
IV_CNT := IV_CNT + 1;
Info(InfoRecog,2,
"Immediate verification: found extra kernel element(s)!");
if FindKernelFastNormalClosure(ri,5,5) = fail then
Expand Down
17 changes: 17 additions & 0 deletions gap/base/recognition.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,23 @@ BindGlobal( "FindHomMethodsGeneric", rec() );
## <#/GAPDoc>
BindGlobal( "SLPforElementFuncsGeneric", rec() );

# TODO Document mandarins
# Refer to overview paper by Baarnhielm, Holt, Charles, Eamonn, sections "5.2
# The main algorithm" and "5.4 Crisis management".
# Explain safe and unsafe nodes.
# Explain in which situations a crisis can be evoked:
# - only in a leaf: mandarin can't be written as SLPs in nice gens, this does
# not happen in non-leaf nodes
# - mandarins can't be mapped under reduction homomorphism
# -
# Note that when implementing verification via presentations, that can also
# evoke crises. Then I'd make sense to remove the "MANDARIN_" prefix from the
# name.
# TODO Wait a second, if the generators of the root can be expressed as SLPs in
# the nice gens, then the kernels must be correct, right?!
BindGlobal("MANDARIN_CRISIS", MakeImmutable("MANDARIN_CRISIS"));
BindGlobal("NUM_MANDARINS_DEFAULT_VALUE", 100);
DeclareFilter( "IsSafeForMandarins" );

# Our global functions for the main recursion:

Expand Down
Loading