Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classical natural tests #200

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ssiccha
Copy link
Collaborator

@ssiccha ssiccha commented Oct 31, 2020

No description provided.

That test is already covered by working/veryslow/ClassicalNatural.tst
@ssiccha ssiccha added the tests label Oct 31, 2020
@ssiccha ssiccha self-assigned this Oct 31, 2020
@ssiccha ssiccha requested a review from fingolfin October 31, 2020 08:19
@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #200 (425df87) into master (4796d16) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   76.37%   76.45%   +0.08%     
==========================================
  Files          37       37              
  Lines       17199    17193       -6     
==========================================
+ Hits        13135    13145      +10     
+ Misses       4064     4048      -16     
Impacted Files Coverage Δ
gap/matrix/matimpr.gi 62.74% <0.00%> (-1.97%) ⬇️
gap/projective/findnormal.gi 78.96% <0.00%> (-0.92%) ⬇️
gap/matrix/ppd.gi 93.16% <0.00%> (-0.86%) ⬇️
gap/projective/d247.gi 75.24% <0.00%> (-0.66%) ⬇️
gap/matrix/classical.gi 55.49% <0.00%> (-0.55%) ⬇️
gap/projective/c6.gi 61.58% <0.00%> (-0.19%) ⬇️
gap/matrix.gi 91.30% <0.00%> (-0.02%) ⬇️
gap/base/recognition.gd 100.00% <0.00%> (ø)
gap/base/recognition.gi 73.93% <0.00%> (+1.28%) ⬆️
gap/perm/giant.gi 90.33% <0.00%> (+2.02%) ⬆️
... and 1 more

@ssiccha
Copy link
Collaborator Author

ssiccha commented Nov 6, 2020

Unfortunately on my machine, some of the smaller GLs fail. relatively regularly. I'll try to find out which ones that are. I have seen that there already are related issues, so I'll look there too.

@fingolfin fingolfin closed this Nov 16, 2020
@fingolfin fingolfin reopened this Nov 16, 2020
@ssiccha ssiccha changed the title Clean up tests Classical natural tests Nov 25, 2020
@fingolfin
Copy link
Member

We now have tst/working/quick/ClassicalNaturalNaming.tst. Might be better to extend that instead. Perhaps also get rid of tst/testclassicalnatural.g; for that, we maybe should...

  • make the number of repetitions in TestNaming an argument??
  • teach TestNaming to use randomize generating sets (but really, even without that we already find plenty bugs)
  • add more input tests; inspired by tst/testclassicalnatural.g and this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants