-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve nice gens functionality and docs #278
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
- Coverage 77.86% 77.86% -0.01%
==========================================
Files 43 43
Lines 18389 18388 -1
==========================================
- Hits 14319 14318 -1
Misses 4070 4070
|
That is install it as a method for `NiceGens` with two arguments. Also improves the documentation of `NiceGens`.
CalcNiceGensGeneric is the method for leaf nodes. So that it doesn't make sense to set this for every node by default. Maybe it once had a different function?
Will be handled during the renaming project.
It looks like this will become a bigger undertaking. 😅 For now I'll add a lot of experimental code to this PR. |
When this is done, @aniemeyer would like to have a look at the docs. |
So far three commits:
CalcNiceGens(r,g)
intoNiceGens(r,g)
CalcNiceGens
and instead install it as a method forNiceGens
with two arguments. Also improves the documentation ofNiceGens
.After that I suggest to rename as follows:
NiceGens
->NiceGenerators
calcnicegens
->NiceGeneratorsFunction
CalcNiceGensGeneric
->NiceGeneratorsForLeafRecogNodes
CalcNiceGensHomNode
->NiceGeneratorsForSplitRecogNodes
pregensfac
->PreImagesOfNiceGeneratorsOfImageRecogNode
Here the corresponding input for mine and @FriedrichRober's script so that I don't loose it: