Mandarin V2 (draft) #312
Draft
Mandarin V2 (draft) #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssiccha
added
the
mandarins
ssiccha
force-pushed
the
ss/mandarins-crisis-handling-option-2
branch
from
2f8a80f to
23d08b2
Compare
Old commit msg of a commit which was squashed into this one and which was nonsense: RecogniseGeneric: recognise image only once This is preparation for the implementation of Mandarins. The following case is going to be handled by the Mandarins. Previously, if in an image node writing of random elements as SLPs in the image node's nice generators failed, that image node would be discarded and recomputed.
and related type and family.
ssiccha
force-pushed
the
ss/mandarins-crisis-handling-option-2
branch
from
23d08b2 to
236e811
Compare
Don't need the "string" overwrite for Set(Parent/Kernel/Image)RecogNode anymore.
This reverts commit b1858e8.
More precisely, of its ValidateHomomInput function.
|
Just wanted to let you know that I still plan to work on this @fingolfin. I obviously didn't have the time lately, but I hope to get around to it in November or December, when work becomes a bit less busy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative handling of crises. Performance is OKish now. I need to clean up and write docs and tests.