Skip to content

Commit

Permalink
Fix FactorCosetAction(G, G) fo perm. groups (#5903)
Browse files Browse the repository at this point in the history
Catch the case of an action with trivial image in
`DoFactorCosetActionPerm`,
and delegate to `DoFactorCosetAction` in this case.
  • Loading branch information
ThomasBreuer authored Jan 11, 2025
1 parent dfc1311 commit 90743e6
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
4 changes: 3 additions & 1 deletion lib/csetperm.gi
Original file line number Diff line number Diff line change
Expand Up @@ -883,10 +883,12 @@ local G,u,op,h,N,rt,ac,actions,hom,i,q;
u:=G;
Error("only trivial operation ? I Set u:=G;");
fi;
if IsSubset(u, G) then
return DoFactorCosetAction(G, u, G);
fi;
if N=false then
N:=Core(G,u);
fi;

ac:=ActionRefinedSeries(G,u);
actions:=ac[2];
ac:=ac[1];
Expand Down
2 changes: 2 additions & 0 deletions lib/factgrp.gd
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,8 @@ DeclareAttribute("NaturalHomomorphismsPool",IsGroup,
##
DeclareOperation( "FactorCosetAction", [IsGroup,IsGroup] );

DeclareGlobalFunction( "DoFactorCosetAction" );

#############################################################################
##
#F ImproveActionDegreeByBlocks( <G>, <N> , <hom> [,forceblocks] )
Expand Down
2 changes: 1 addition & 1 deletion lib/factgrp.gi
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ end);
#F FactorCosetAction( <G>, <U>, [<N>] ) operation on the right cosets Ug
## with possibility to indicate kernel
##
BindGlobal("DoFactorCosetAction",function(arg)
InstallGlobalFunction("DoFactorCosetAction",function(arg)
local G,u,op,h,N,rt;
G:=arg[1];
u:=arg[2];
Expand Down
2 changes: 2 additions & 0 deletions tst/teststandard/permgrp.tst
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ gap> u:=Normalizer(g,SylowSubgroup(g,3));;
gap> act:=FactorCosetAction(g,u);;
gap> NrMovedPoints(Range(act));
70840
gap> NrMovedPoints(Range(FactorCosetAction(g,g)));
0

#
gap> STOP_TEST("permgrp.tst");

0 comments on commit 90743e6

Please sign in to comment.