-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'gap --version' to send its output to stdout and include a trailing newline #5864
Fix 'gap --version' to send its output to stdout and include a trailing newline #5864
Conversation
OK it seems the issue is caused by our file descriptors not being initialized yet. The means the other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like there are too many line breaks now:
$ ./gap --version
GAP
4.14.0-22-g00e3a64
built on
2024-12-09 11:12:42-0600
I can confirm that |
3219249
to
9dbae20
Compare
|
Also add a trailing newline.
9dbae20
to
a18a932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Backported to |
Also add a trailing newline.
Apparently it was printing to
stdin
before. Even after looking at the code I completely fail to see why it did that. But while I'd love to get to the bottom of this, let's first get this trivial fix out of the door.