Fix potential race condition in make install
#5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: bug
This comment was marked as outdated.
This comment was marked as outdated.
Also don't install a second GAP executable as `$(libdir)/gap`: no package nor anything else should need this anymore.
fingolfin
force-pushed
the
mh/fix-parallel-make-install
branch
from
9658aa9 to
79f435e
Compare
ChrisJefferson
approved these changes
Jan 7, 2025
|
I can't reproduce the original issue with or without this patch, but I hope it will help and at worst it shouldn't harm anything... |
fingolfin
added
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also don't install a second GAP executable as
$(libdir)/gap: no package nor anything else should need this anymore.Supposed to fix #5882 -- however, I have not yet tested it at all -- I'll wait for CI to report back to see if it works under "normal" conditions and will look into reproducing the original issue when I have time.
That said, feel free to try it out @mkoeppe (but I assume you have many other things up your plate)