kernel: consistent types for argc, argv #5897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
fingolfin
force-pushed
the
mh/argv-typing
branch
2 times, most recently
from
0106636 to
6e3d94a
Compare
Also add a comment explaining why `InitializeGap` takes a *pointer* to `argc` instead of `argc` directly.
fingolfin
force-pushed
the
mh/argv-typing
branch
from
6e3d94a to
cd98a79
Compare
ChrisJefferson
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a comment explaining why
InitializeGaptakes a pointer toargcinstead ofargcdirectly.(This is another semi-trivial PR in my series working towards refactoring
InitSystem)