vscode settings and reccomendations #1
Conversation
|
Awesome! |
|
also it looks like we are adding a yarn.lock here, is that customary for a starter? |
|
Yeah, I think Though I'm wondering if we should maybe wait to merge this PR until the other features for the GraphQL extension are working again. What do you think? The starter should ideally be a good starting point for someone brand new to Gatsby so if we add the GraphQL plugin and folks can't quite yet understand/see what it's for it might be confusing. |
acao
force-pushed
the
chore/vscode-config
branch
from
75821ff to
0ddaad9
Compare
|
@TylerBarnes i think gatsby is standardizing around npm, so i've re-written the last commit to add that instead. adding the lockfile might just make sense in a different PR though. it adds a lot of functionality as it is, and works out of the box, and it will be a long while before I'll be able to find the time to fix those (non visible) bugs in the LSP |
| @@ -37,6 +37,7 @@ module.exports = { | |||
| */ | |||
| `gatsby-transformer-sharp`, | |||
| `gatsby-plugin-sharp`, | |||
| `gatsby-plugin-graphql-config`, | |||
There was a problem hiding this comment.
Can you add some space above this + a comment linking to the GraphQL config plugin docs? Similar to the style of the other plugins. I want to make sure any new folks who use this can "explore or ignore" 😛
|
Sounds good! In that case I left 1 comment :) |
default vscode settings for the workspace and plugin reccomendations! check it out.
vscode-graphqlfeatures will appear after develop process has been run. probably should add docs for that, maybe a launcher as wel??