Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/kernel thinning backup #915

Merged
merged 12 commits into from
Jan 15, 2025
Merged

Feature/kernel thinning backup #915

merged 12 commits into from
Jan 15, 2025

Conversation

qh681248
Copy link
Contributor

@qh681248 qh681248 commented Jan 3, 2025 •
edited
Loading

PR Type

  • Feature

Description

Add Kernel Thinning and make it an explicit sized solver

How Has This Been Tested?

Existing tests pass as expected.

New tests to be added

Does this PR introduce a breaking change?

No

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Performance review

Commit b9a2b28 - Merge eaeab2d into 770ed2a

No significant changes to performance.

gw265981
gw265981 reviewed Jan 9, 2025
View reviewed changes
coreax/solvers/coresubset.py Show resolved Hide resolved
coreax/solvers/coresubset.py Outdated Show resolved Hide resolved
coreax/solvers/coresubset.py Show resolved Hide resolved
coreax/solvers/coresubset.py Outdated Show resolved Hide resolved
coreax/solvers/coresubset.py Show resolved Hide resolved
coreax/solvers/coresubset.py Show resolved Hide resolved
coreax/solvers/coresubset.py Outdated Show resolved Hide resolved
coreax/solvers/coresubset.py Outdated Show resolved Hide resolved
coreax/solvers/coresubset.py Outdated Show resolved Hide resolved
coreax/solvers/coresubset.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit f37fab0 - Merge bc690c2 into fde187f

No significant changes to performance.

@qh681248 qh681248 marked this pull request as ready for review January 13, 2025 09:21
This was linked to issues Jan 13, 2025
Kernel Thinning #688
Closed
Add KT-split algorithm #863
Closed
Add KT-select_best algorithm #864
Closed
Add KT-refine algorithm #865
Closed
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 85697aa - Merge 5b50f94 into fde187f

No significant changes to performance.

gw265981
gw265981 reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@gw265981 gw265981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more minor changes.

coreax/solvers/coresubset.py Show resolved Hide resolved
coreax/solvers/coresubset.py Outdated Show resolved Hide resolved
coreax/solvers/coresubset.py Outdated Show resolved Hide resolved
tests/unit/test_solvers.py Outdated Show resolved Hide resolved
tests/unit/test_solvers.py Outdated Show resolved Hide resolved
tests/unit/test_solvers.py Show resolved Hide resolved
coreax/solvers/coresubset.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit b0d5956 - Merge 4c583f7 into 65b25cb

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit d4c18ec - Merge e9990cd into 65b25cb

No significant changes to performance.

@gw265981 gw265981 merged commit f128b65 into main Jan 15, 2025
19 checks passed
@gw265981 gw265981 deleted the feature/kernel_thinning_backup branch January 15, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gw265981 gw265981 gw265981 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add KT-refine algorithm Add KT-select_best algorithm Add KT-split algorithm Kernel Thinning
2 participants
@qh681248 @gw265981