Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest errors in examples #921

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix pytest errors in examples #921

wants to merge 3 commits into from

Conversation

rg936672
Copy link
Contributor

@rg936672 rg936672 commented Jan 10, 2025

PR Type

  • Bugfix

Description

Closes #913.

How Has This Been Tested?

Existing tests pass as expected.

pyright examples passes without errors.

Added a workflow that runs pyright coreax examples to ensure that both the main Coreax package and the example scripts continue to pass Pyright. (The main package was done in #906.)

Does this PR introduce a breaking change?

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

Copy link
Contributor

Performance review

Commit 615b16c - Merge 2829ba6 into fde187f

No significant changes to performance.

Copy link
Contributor

Performance review

Commit 24204de - Merge dbe9994 into fde187f

No significant changes to performance.

Copy link
Contributor

Performance review

Commit 23f2b1b - Merge e4b253d into fde187f

No significant changes to performance.

@rg936672 rg936672 force-pushed the fix/pyright/examples branch from e4b253d to 28021ca Compare January 10, 2025 11:15
Copy link
Contributor

Performance review

Commit d701488 - Merge 28021ca into fde187f

No significant changes to performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix static type checker complaints for examples
1 participant