Gh-236: Update GH actions #327
Conversation
|
| @@ -60,3 +41,14 @@ jobs: | |||
| git checkout -b $BRANCH_NAME | |||
| git commit -a -m "prepare release $artifactId-$RELEASE_VERSION" | |||
| git push --set-upstream origin $BRANCH_NAME | |||
|
|
|||
| - name: Tag release branch | |||
There was a problem hiding this comment.
Just to check, as the previous releases were tagged, I'm guessing that used to be done using the steps above which have been removed?
There was a problem hiding this comment.
I think the tags must have been applied manually the removed steps don't seem to have done any tagging they just worked out the version. The tagging was previously done by the release.yaml by the looks of it.
There was a problem hiding this comment.
I don't recall them being applied manually - which is why I'd commented, but as you say there doesn't appear have been anything which did this. In any case, as it is now there won't be any other steps which could apply tags beyonf this one, so this should be fine.
Updated the relevant GH actions. Also replaced the
actions-ecosystem/action-get-latest-tagin the hotfix workflow.Updated the release process to be the same as other Gaffer repos.
Related issue