Feature/fix config parameter #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, --config parameters were parsed as 'normal' doubledashed parameters in gdal_cmd_builder. However, this --config options must be provided as key value pairs like `gdalinfo /some/image.tif --config GDAL_CACHEMAX "30%" for setting the maximum cache to 30 percent of the system memory. This commit introduces changes to the creation of the gdal commands in gdal_cmd_builder.R to introduce the general functionality. Further, all functions which already incorporate a config parameter were adjusted to make use of the new functionality. In the case of gdalinfo the "config" parameter was moved from character parameters to repeatable parameters, which is in line with the handeling in all other functions.
The documentation of the newely added parameter_named was adapted. Also in the documentation in all functions having a config parameter were the config parameter was changed to a named character.
After checks, devtools::document() was used to update the documentation. The package builds and tests without any errors, warnings and notes.
|
@rolfsimoes Thanks for your help. I resolved the few comments. |
rolfsimoes
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #30
It introduces a
parameter_namedtogdal_cmd_builder()which allows to parse options built on key value pairs. It is specifically designed to support adding e.g.--config GDAL_CACHEMAX "30%"or alike to gdal commands where suitable.I would kindly like to ask @rolfsimoes for a code review.