Add split-output option #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
option behavior added to the GET request. |
ozguzMete
force-pushed
the
retry-failed-annotations
branch
3 times, most recently
from
41e99ad to
94133cf
Compare
|
dump-failed option is added. if the output file is x.txt and this option is present, failed annotations will be written additionally to a file named x.txt.FAILED. |
ozguzMete
force-pushed
the
retry-failed-annotations
branch
from
94133cf to
edda1f1
Compare
|
The removed test file is old and fails ci/circleci:build. |
ozguzMete
force-pushed
the
retry-failed-annotations
branch
6 times, most recently
from
8bb978d to
fe56fcb
Compare
inodb
reviewed
Aug 16, 2022
| @@ -65,6 +65,7 @@ private static Options getOptions(String[] args) | |||
| .addOption("i", "isoform-override", true, "Isoform Overrides (mskcc or uniprot)") | |||
| .addOption("e", "error-report-location", true, "Error report filename (including path)") | |||
| .addOption("r", "replace-symbol-entrez", false, "Replace gene symbols and entrez id with what is provided by annotator" ) | |||
| .addOption("s", "dump-failed", false, "Write failed annotations into an additional file" ) | |||
There was a problem hiding this comment.
Suggested change
| .addOption("s", "dump-failed", false, "Write failed annotations into an additional file" ) | |
| .addOption("s", "dump-failed", false, "Write failed annotations into an additional file <output-filename>.FAILED" ) |
ozguzMete
force-pushed
the
retry-failed-annotations
branch
2 times, most recently
from
ab753d8 to
6aacd60
Compare
|
I have renamed dump-failed to split-output because we started to produce SUCCESS file. |
ozguzMete
force-pushed
the
retry-failed-annotations
branch
from
6aacd60 to
feaee5a
Compare
|
we might want to keep this on hold until the big file support goes live |
ozguzMete
force-pushed
the
retry-failed-annotations
branch
3 times, most recently
from
bd14959 to
9c18cb5
Compare
ozguzMete
force-pushed
the
retry-failed-annotations
branch
from
9c18cb5 to
327e277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option creates two additional files for failed and successful annotations.