add options to connect to database for c. annotation #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leexgh
reviewed
Nov 6, 2024
| @@ -98,4 +98,67 @@ public void fetchVepAnnotationByRegionsPOST( | |||
| return; | |||
| } | |||
|
|
|||
| @RequestMapping(value = "/vep/human/hgvsc/{hgvsc}", | |||
There was a problem hiding this comment.
Since database is optional, should we hide or disable this endpoint when no database?
| } | ||
| } | ||
|
|
||
| @RequestMapping(value = "/vep/human/hgvsc", |
There was a problem hiding this comment.
Same here, should we hide or disable this endpoint when no database?
inodb
reviewed
Nov 19, 2024
Comment on lines
46
to
68
| @Value("${database.grch37.host}") | ||
| private String grch37DatabaseHost; | ||
|
|
||
| @Value("${database.grch37.port}") | ||
| private String grch37DatabasePort; | ||
|
|
||
| @Value("${database.grch37.user}") | ||
| private String grch37DatabaseUser; | ||
|
|
||
| @Value("${database.grch37.password}") | ||
| private String grch37DatabasePassword; | ||
|
|
||
| @Value("${database.grch38.host}") | ||
| private String grch38DatabaseHost; | ||
|
|
||
| @Value("${database.grch38.port}") | ||
| private String grch38DatabasePort; | ||
|
|
||
| @Value("${database.grch38.user}") | ||
| private String grch38DatabaseUser; | ||
|
|
||
| @Value("${database.grch38.password}") | ||
| private String grch38DatabasePassword; |
There was a problem hiding this comment.
let's use similar setup here as for the genome nexus backend (one vep per genome nexus instance), so maybe this can be simplified to database.host database.port etc
remove password
bprize15
force-pushed
the
feat/add-cdna-endpoints
branch
from
04056fe to
9903e84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for connecting to MySQL database to annotate c. variants