Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status bar to map #348

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Jan 16, 2025

Description

Addresses #306, #316, and maybe #309

Adds a status bar to the map showing a loading indicator, version number, coordinates, and view projection.

I'd appreciate some input on how it looks and which information we want to put on it.

Loading:
statubar

Loaded:
statusbarnoload

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--348.org.readthedocs.build/en/348/
💡 JupyterLite preview is available from the doc, by clicking on lite badge

@gjmooney gjmooney added the enhancement New feature or request label Jan 16, 2025
@gjmooney gjmooney self-assigned this Jan 16, 2025
Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/status_bar

Copy link
Contributor

Integration tests report: appsharing.space

@brichet
Copy link
Collaborator

brichet commented Jan 16, 2025

This is great, thanks for working on this @gjmooney.

which information we want to put on it.

I don't know how complicated it is, but having it configurable would be wonderful, from the settings or a context menu on the bar itself.

@mfisher87
Copy link
Member

This is absolutely beautiful, Greg! I love having the projection info always displayed in the bottom-right like QGIS. What do you think of also including a "scale" indicator on the bar to meaningfully indicate zoom level? Similar to QGIS, expressed as a ratio of 1:n?

@mfisher87
Copy link
Member

mfisher87 commented Jan 16, 2025

Huge nitpick: The JGIS version number and the right edge of the loading bar bounce around the slightest bit when the coordinates update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants