4.2.6 #259
Closed
4.2.6 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de (#7034) * Verify the portal requested exists - configure servlet names to exclude. Related to #6970 * Use AntPathRequestMatcher for checking if a request matches or not. * Use Ant patterns in web.xml to define the paths. --------- Co-authored-by: Juan Luis Rodríguez <[email protected]>
Following trivy tool scanning report.
* PDF / Report image URL in case of error Provide some more context to user about the error ``` 2023-04-26T12:37:21,072 ERROR [geonetwork] - Error writing metadata to PDF java.lang.IllegalArgumentException: URI is not absolute at java.net.URI.toURL(URI.java:1088) ~[?:1.8.0_362] at org.fao.geonet.api.records.formatters.ImageReplacedElementFactory$UrlImageLoader.loadImage(ImageReplacedElementFactory.java:289) ~[classes/:?] ``` replaced by ``` 2023-04-26T12:46:31,470 ERROR [geonetwork] - Error loading image /images/logos/c9c5a394-882a-4520-8011-7f6c11ffaa5a.png for PDF java.lang.IllegalArgumentException: URI is not absolute at java.net.URI.toURL(URI.java:1088) ~[?:1.8.0_362] ``` Logging as warning as it is not blocking PDF creation. * PDF / Avoid error on logo image URL
* change the method for the password's minLength to be max, so if a bigger value than 6 is retrieved from "system.security.passwordEnforcement.minLength" this is taken into account * merge conflict * "download metadata" button in default editor view opens the xml in a new tab, consistent behaviour with the rest of the download buttons
See https://bugzilla.mozilla.org/show_bug.cgi?id=765035 https://www.w3.org/TR/CSS2/generate.html#before-after-content Replace CSS after by icon checking input validity.
* Import metadata / If workflow is enable hide validation and publish option. When workflow is enabled, usually extra rules apply to publish or validate records. So don't let the user set those option while importing a new record. Let the record enter the workflow and follow the proper steps. * Import metadata / If workflow is enable hide validation and publish option / Allow validation. * Import metadata / If workflow is enable publish parameter of import API is forced to false. * Import metadata / If workflow is enable publish parameter of import API is forced to false (additional API endpoint). --------- Co-authored-by: Jose García <[email protected]>
* Translation to Danish Translation into Danish has being done in Transifex by Danish Agency for Data Supply and Infrastructure (INSPIRE contact point and maintainer of the Danish Geodata catalogue). * Translation into Danish Translation has been done in Transifex by Agency for Data Supply and Infrastructure (INSPIRE contact point) * Delete da-admin.json The file was in a wrong folder * Delete da-core.json The file was in a wrong folder * Delete da-editor.json The file was in a wrong folder * Delete da-search.json The file was in a wrong folder * Delete da-v4.json The file was in a wrong folder * Delete CatController.js The file was in a wrong folder * Danish added Danish (da, dan, Danish) added as language. * i18n / Add db init files for Dansk. Reorder languages. * Added Danish as translated langauge * i18n / Transifex / Fix code for Dansk. * File translated to Danish Location: /web/src/main/webapp/WEB-INF/classes/setup/sql/data/loc-dan-default.sql --------- Co-authored-by: +larsStorgaard[ 1..*] <[email protected]>
… (#6967) * Editor / Suggestions / Suggest date depending on status. Once the status of the record is set, check that a corresponding date is also defined. If not, suggest to add one. * Editor / Suggestions / Suggest date depending on status / ISO19139 support. * Editor / Suggestions / Suggest date depending on status / ISO19139 support / Register suggest. * Editor / Suggest action / Hide action if none found * Update schemas/iso19115-3.2018/src/main/plugin/iso19115-3.2018/process/add-date-for-status-common.xsl Co-authored-by: Jose García <[email protected]> --------- Co-authored-by: Jose García <[email protected]>
…tifier (#6976) Same as https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19139/src/main/plugin/iso19139/update-fixed-info.xsl#L147-L158 Even if most of the users don't use the parentMetadata for collection/series/partOfSeamlessDatabase relation type and if create child record was removed in geonetwork/core-geonetwork#6708, some users (eg. ifremer) still use this encoding.
* Editing / dateStamp = changeDate on update On metadata update, `BaseMetadataManager` is calling `update-fixed-info` which set `dateStamp` from metadata table `changeDate` but the table is only updated after in `XmlSerializerDb`. The dateStamp is using the previous changeDate (usually a short time before last edit on an editing session with multiple actions). If user just open the editor and save and close directly, the dateStamp is set to the last editing date (which could be long time ago). In the index, we expect to have `dateStamp` = `changeDate` but it was not the case. * Update core/src/main/java/org/fao/geonet/kernel/datamanager/base/BaseMetadataManager.java Co-authored-by: Jose García <[email protected]> --------- Co-authored-by: Jose García <[email protected]>
If URL is not available, this can slow down indexing. Adding a timeout to avoid to wait too long for downloading overview. If not available, the overview URL is used client side instead of the small overview added to the index document.
Vertical range are gco:Real so index them as numbers and also properly compared negative values. A record with the following ```xml <gex:verticalElement> <gex:EX_VerticalExtent> <gex:minimumValue> <gco:Real>-2140.02</gco:Real> </gex:minimumValue> <gex:maximumValue> <gco:Real>-2.5</gco:Real> </gex:maximumValue> <gex:verticalCRS/> </gex:EX_VerticalExtent> </gex:verticalElement> ``` only the minimum value was indexed due to text comparison.
* Indexing / More robust on invalid thesaurus type Fixes for geonetwork/core-geonetwork#7051. ISO19139 and ISO19115-3 codelist for keyword type is only contains of letters eg. theme, place, discipline. Some users are reporting invalid metadata with keyword title in the keyword type (!) which cause an indexing error. Making the indexing more robust on this case only allowing letters and `-_.` in codelist type. * Update index-utils.xsl
metadata: creation = considered "modified" (md is created when ressource is loaded) revision = "metadata processed" publication = "modified" ressource: creation = not avavailable in ods revision = "data processed" publication = "modified"
When requesting link report for a large set of records in a selection, request URI may be too long depending on proxy. Use POST instead of GET.
this accepts - and / as date separators and just whitespace chars between date and time
* disable link to parent button to use ng-disabled * disable link to parent button to use ng-disabled.
Some users are referencing CF standard names (https://cfconventions.org/Data/cf-standard-names/current/build/cf-standard-name-table.html) in keywords which can contains long values and display is not that nice. Improving it. Create a record with ```xml <gmd:descriptiveKeywords> <gmd:MD_Keywords> <gmd:keyword> <gco:CharacterString>altitude_at_top_of_atmosphere_mixed_layer_defined_by_ambient_aerosol_particles_backwards_scattering_by_ranging_instrument</gco:CharacterString> </gmd:keyword> <gmd:type> <gmd:MD_KeywordTypeCode codeList="http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#MD_KeywordTypeCode" codeListValue="cfstandardname" codeSpace="ISOTC211/19115"/> </gmd:type> </gmd:MD_Keywords> </gmd:descriptiveKeywords> ``` for testing.
The link field was missing and the map link was empty. So the map was not displayed.
…used. Users use associated resources for this type of links.
…metadataReference.
* WFS layer improvements QGIS Server may not advertised namespace for feature type eg. https://geodata.valenceromansagglo.fr/api/ogc?SERVICE=WFS&REQUEST=GetCapabilities * WFS / Add missing version parameter Make WFS feature type search more similar to what is done for WMS layer. Add the version property which is used later on in https://github.com/geonetwork/core-geonetwork/blob/main/web-ui/src/main/resources/catalog/components/common/map/mapService.js#L1460 when adding the vector source.
* Add icons for related types (association and initiative) in the editor and the footer of a card view. --------- Co-authored-by: François Prunayre <[email protected]>
* Map / WMS dimension saved in map Save current map dimension value in the map context to be able to open a map on specific date. Follow up of geonetwork/core-geonetwork#6820 " * Map / Layer enabled in layer manager status saved in context.
…'gnCfg.mods.authentication.enabled' is disabled
…ted to #5941 (#7361)
Follow up of geonetwork/core-geonetwork#7340 Clarify coordinate order for geo_shape field: "In GeoJSON and WKT, and therefore Elasticsearch, the correct coordinate order is longitude, latitude (X, Y) within coordinate arrays. This differs from many Geospatial APIs (e.g., Google Maps) that generally use the colloquial latitude, longitude (Y, X)." Test : * https://www.geocat.ch/geonetwork/srv/api/records/78a41177-6125-4f11-ac8b-4ec6166dad70/formatters/iso19139?output=xml * check coordinate order in default view (advanced view is fine because base on the XML)
* Improved handling of empty titles * Fixed mdResourceTitle typo
Add support for emails with subdomains : [email protected] Fix text duplication when a mail is substituted.
…dmin page (#7354) * fix for untranslated userRecord and userRecords labels in user admin page * converting quotes to alphanumeric
* Index and display resourceEdition * Index properly date time * Set version data as the revision date (so it is displayed in record view) * Index producer as feature catalog contact and metadata contact * Record view / Do not display spatial section if no information * Record view / Fix identifier translation in title attribute
…approved - fill missing information for submitter, reviewer and publisher user (#7292)
* Update api for associated resources and related resource to support supplying the approved flag. * Only apply approved=false if it is a draft. No need to use approved=true as it is the default. * Update function to support approved flag on related function call and add todos * Update services/src/main/java/org/fao/geonet/api/records/MetadataApi.java Co-authored-by: Jose García <[email protected]> * Update web-ui/src/main/resources/catalog/components/edit/onlinesrc/OnlineSrcService.js Co-authored-by: Jose García <[email protected]> * Update web-ui/src/main/resources/catalog/components/edit/onlinesrc/OnlineSrcService.js Co-authored-by: Jose García <[email protected]> * Applied changes recommended in PR review * Applied some other changes to fix deletion Updated some formatting * Refactor duplicate code * Change api so that it does not add approve=false to the urls as it was causing other issues. * Fix thumbnails on approve/working copy display. Updated missing parameter from related get function added uuid in regex search to be more accurate. * Use md instead of gnCurrentEdit.metadata * Fixed some api calls to use approved flag. * Use src in popup for gnImgModal when possible as it may have the approved=false * Don't fail if metadataUuid is an id. * Fix missing & in approval append * Check for draft === "y" instead of just checking if variable exists. * Refactor canViewRecord based on code review suggestions. * Refactored another canViewRecord that was missed --------- Co-authored-by: Jose García <[email protected]> Co-authored-by: Ian <[email protected]>
In ISO, a record may have more than one status even if not common. Fix the overlapping status badge by a dedicated container displaying all status. In the search results, only the first status is displayed (and others are listed in the tooltip). Co-authored-by: Joachim Nielandt <[email protected]>
* batch edit user profile check in APIs * protect search-and-replace API
* online help ported from hnap manual * translate module from hnap prototype Expanded to convert from sphinx * Update help to match discussion * some sample pages to test translate script from rst to md * Testing translate pandoc rst to markdown * Changes to style and theme: - add browser window style - colors - add extension and features * pre/post * overview section * overview section * Changes to style and theme: - add browser window style - colors - add extensions and features * update translate rst command for directory processing * bulk covert change-log * api content * fix quickstart formatting * user-guide landing page * anchors lookup from rst files * example of fixing an broken anchor link * include version text to avoid i18n issue * Document include plugin for use to inline content from other files * Handle rst fenced blocks like note and warning (and deprecated and see also) * admin guide > managing metadata standards * Remaining admin guide pages * Review of admin-guide fixing common indenting rst mistakes These introduce random block quotes when none is intended * install-guide * contributing * tutorials * customizing application * special logic needed for admonition * maintainer guide * user guide update * Some updates to files corrected by hand earlier * anenxes * integrate into maven build * Work on reducing download size of manual * Fixing indents for lists and code blocks, and thus removing blockquotes in the resulting pages * Improve indents and TOC, add tabs, add copy to clipboard for code blocks and smart symbols, add extra text to the footer * Improve order and titles of pages * work on appearance * work on translating doc references * work on index headings * back convert to rst any manual changes perofrmed to markdown * switch to preprocessing references * Second check of script generated conversion * restore change log pages, requires update of mkdocs-static-i18n>=1.0.5 * Fold in online help and clean up nav structure * update doc links to index.rst files * Update script to better handle links to index.rst files * small corrections from review with jose * recover mef docs from 2.10.x branch * index rst files for doc conversion * update anchors.txt index based on improved rst scan * remove help module, added as distinct assembly to manual * no parameter doc conversion * Version management with mike * Move translate script * update to toctree conversion with document titles * process reference links using anchors_txt index * script fixes for heading length, rst_epilog substitutions, and reference titles * clearn conversion, although warning while serving due to absolute links * change to generating relative links * clean up warnings * include version changes in title index * regenerat version changes now that we have references working * clean up gallery warnings * adjust nav * Fix numbering and admonitions on some pages, fixing some edge cases, adding language to code blocks * Fix arrows (-->) with `Smart Symbols` and add grid to startup page * Use less lines in the footer and fix the version toc * Fix the grid on the first page - remove the uneven gap * Update content structure and address feedback geonetwork/core-geonetwork#7363 * translate script removed to its own repository * langauge chooser by default * publish french to mike versions by default * Add suite_url so that language chooser works with mike versioning * update deployment and translation instructions * remove development feedback banner * Fix for the grid on the starting page, make it responsive * Change to major.minor examples and use of remote for docs.geonetwork-opensource.org publishing We will need to test edit link and other features once this is deployed * geonetwork icons * Add a gitignore include so that overrides/.icons is version controlled correctly * remove manuals submodule This was no longer included in the build * describe the repo as core-geonetwork in header * troubleshooting mike deploy * continue to troubleshoot mike deploy * working on mike instructions --------- Co-authored-by: Michel Gabriel <[email protected]>
Related records are available from the search API. For draft, no records are returned because the search was made by UUID instead of ID.
…(#7380) * Update link to the 4.2 manual * Update install guide * Update release scripts to remove Sphinx docs updates and fix SQL migration script folder name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.