feat(minio): add MinIO support alongside AWS S3 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
electrosenpai
commented
Sep 10, 2024
•
electrosenpai
commented
- Updated Chart.yaml to include MinIO as a conditional dependency
- Modified api-deployment.yaml to dynamically set environment variables based on the chosen provider (AWS S3 or MinIO)
- Adjusted values.yaml to include configuration options for MinIO, while keeping existing AWS S3 settings
- Updated Chart.yaml to include MinIO as a conditional dependency - Modified api-deployment.yaml to dynamically set environment variables based on the chosen provider (AWS S3 or MinIO) - Adjusted values.yaml to include configuration options for MinIO, while keeping existing AWS S3 settings
electrosenpai
force-pushed
the
add-minio
branch
from
c64a2cd to
37bdf18
Compare
- Updated templates/minio.yaml to apply release-specific secrets for MINIO_ROOT_USER and MINIO_ROOT_PASSWORD - Modified values.yaml to configure MinIO as the S3 provider and to allow for dynamic resource naming using fullnameOverride
- Added MinIO support as an alternative to AWS S3 in - Modified to reflect new MinIO settings outside the S3 configuration - Updated with MinIO as a conditional dependency - Removed as it is no longer required - Ensured proper environment variables for MinIO and AWS S3 are set dynamically
…e account, and secret management for MinIO integration
…MinIO-specific secrets correctly
…chart - Remove the `create-minio-bucket` init container since the MinIO chart now handles bucket creation via the `buckets` configuration. - Update the `LAGO_AWS_S3_BUCKET` environment variable to use the name of the first bucket defined in `minio.buckets`. - Enable MinIO in `values.yaml` by setting `enabled: true`. - Add the (commented) bucket configuration in `values.yaml` with a note indicating that only the first bucket will be used. This change simplifies deployment by leveraging the MinIO chart's built-in mechanism for bucket creation, eliminating the need for a custom script.
…ket configuration
electrosenpai
changed the title
jdenquin
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.