Skip to content

Commit

Permalink
Bump Node version matrix
Browse files Browse the repository at this point in the history
Manually verified on 22.12.0 (in case `tree-sitter` et al have issues):

- clean install
- monorepo-wide build
- monorepo-wide test (partial run of flaky `web-forms` e2e tests, accepting that they were already flaky and shouldn’t be otherwise affected by this change)
  • Loading branch information
eyelidlessness committed Dec 16, 2024
1 parent 744b38e commit 7ea1dc7
Show file tree
Hide file tree
Showing 8 changed files with 32 additions and 32 deletions.
48 changes: 24 additions & 24 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:

strategy:
matrix:
node-version: ['18.20.4', '20.17.0', '22.9.0']
node-version: ['18.20.5', '20.18.1', '22.12.0']

steps:
- uses: 'actions/checkout@v4'
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:

strategy:
matrix:
node-version: ['22.9.0']
node-version: ['22.12.0']

steps:
- uses: 'actions/checkout@v4'
Expand Down Expand Up @@ -130,16 +130,16 @@ jobs:
strategy:
matrix:
target: ['Node']
node-version: ['18.20.4', '20.17.0', '22.9.0']
node-version: ['18.20.5', '20.18.1', '22.12.0']
include:
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: chromium
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: firefox
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: webkit

steps:
Expand Down Expand Up @@ -195,16 +195,16 @@ jobs:
strategy:
matrix:
target: ['Node']
node-version: ['18.20.4', '20.17.0', '22.9.0']
node-version: ['18.20.5', '20.18.1', '22.12.0']
include:
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: chromium
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: firefox
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: webkit

steps:
Expand Down Expand Up @@ -260,16 +260,16 @@ jobs:
strategy:
matrix:
target: ['Node']
node-version: ['18.20.4', '20.17.0', '22.9.0']
node-version: ['18.20.5', '20.18.1', '22.12.0']
include:
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: chromium
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: firefox
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: webkit

steps:
Expand Down Expand Up @@ -325,16 +325,16 @@ jobs:
strategy:
matrix:
target: ['Node']
node-version: ['18.20.4', '20.17.0', '22.9.0']
node-version: ['18.20.5', '20.18.1', '22.12.0']
include:
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: chromium
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: firefox
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: webkit

steps:
Expand Down Expand Up @@ -395,7 +395,7 @@ jobs:

strategy:
matrix:
node-version: ['18.20.4', '20.17.0', '22.9.0']
node-version: ['18.20.5', '20.18.1', '22.12.0']

steps:
- uses: 'actions/checkout@v4'
Expand Down Expand Up @@ -440,16 +440,16 @@ jobs:
strategy:
matrix:
target: ['Node']
node-version: ['18.20.4', '20.17.0', '22.9.0']
node-version: ['18.20.5', '20.18.1', '22.12.0']
include:
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: chromium
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: firefox
- target: 'Web'
node-version: '22.9.0'
node-version: '22.12.0'
browser: webkit

steps:
Expand Down Expand Up @@ -503,7 +503,7 @@ jobs:
- if: ${{ matrix.target == 'Web' && matrix.browser != 'webkit' }}
run: 'yarn workspace @getodk/web-forms test-browser:${{ matrix.browser }}'

- if: ${{ matrix.node-version == '22.9.0' && matrix.target == 'Node' }}
- if: ${{ matrix.node-version == '22.12.0' && matrix.target == 'Node' }}
uses: actions/upload-artifact@v4
with:
name: dist-demo
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
"type": "module",
"version": "0.1.0",
"engines": {
"node": "^18.20.4 || ^20.17.0 || ^22.9.0",
"node": "^18.20.5 || ^20.18.1 || ^22.12.0",
"yarn": "1.22.22"
},
"volta": {
"node": "22.9.0",
"node": "22.12.0",
"yarn": "1.22.22"
},
"packageManager": "[email protected]",
Expand Down
2 changes: 1 addition & 1 deletion packages/common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"README.md"
],
"engines": {
"node": "^18.20.4 || ^20.17.0 || ^22.9.0",
"node": "^18.20.5 || ^20.18.1 || ^22.12.0",
"yarn": "1.22.22"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/scenario/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"./types/do-not-import.d.ts"
],
"engines": {
"node": "^18.20.4 || ^20.17.0 || ^22.9.0",
"node": "^18.20.5 || ^20.18.1 || ^22.12.0",
"yarn": "1.22.22"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/tree-sitter-xpath/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"tree-sitter-xpath.wasm"
],
"engines": {
"node": "^18.20.4 || ^20.17.0 || ^22.9.0",
"node": "^18.20.5 || ^20.18.1 || ^22.12.0",
"yarn": "1.22.22"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/web-forms/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"README.md"
],
"engines": {
"node": "^18.20.4 || ^20.17.0 || ^22.9.0",
"node": "^18.20.5 || ^20.18.1 || ^22.12.0",
"yarn": "1.22.22"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/xforms-engine/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"README.md"
],
"engines": {
"node": "^18.20.4 || ^20.17.0 || ^22.9.0",
"node": "^18.20.5 || ^20.18.1 || ^22.12.0",
"yarn": "1.22.22"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/xpath/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"README.md"
],
"engines": {
"node": "^18.20.4 || ^20.17.0 || ^22.9.0",
"node": "^18.20.5 || ^20.18.1 || ^22.12.0",
"yarn": "1.22.22"
},
"scripts": {
Expand Down

0 comments on commit 7ea1dc7

Please sign in to comment.