Fix: Web Forms Preview demo form links #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nature of this fix is that Vite’s `import.meta.glob` produces a build-time asset URL, which we used previously, but missed in the generalization of glob import loading. This was missed because the dev/test asset URL is identical to the relative path key which we did use in that generalization. Since this implicates an important difference betwen dev/test and build, an e2e test will follow to exercise loading demo forms directly from the Web Forms Preview build product.
Includes a couple of small template changes: - Explicit selector for identifying the links themselves - Selector for identifying when a form has completed loading, and what its loading status is The test itself checks for either an error or ready status, and then explicitly checks that no error message is displayed. I think this makes the test’s _intent_ clear enough that it’ll hopefully be maintainable longer term (whereas I struggle to understand some of the existing e2e tests when I look back at them after any length of time).
|
|
I don't think this needs a changeset? It should hopefully only affect the Web Forms Preview secondary build product. |
eyelidlessness
changed the title
lognaturel
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
Added an e2e test which loads all of the Web Forms Preview form links, from the build product. That should be much more reliable than any manual testing I might do.
Why is this the best possible solution? Were any other approaches considered?
It would be preferable if specific fixtures could be referenced by something stable, and not rely on anything dynamic at build time.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It's possible some other nuance of glob loading is affected by this. But I would expect to see some sign of that either in
scenarioor dev mode, both of which still seem to be working as expected.Do we need any specific form for testing your changes? If so, please attach one.
The links on the preview page should suffice.
What's changed