-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize files - html, xml, js, json, css and svg compression using m… #1199
Open
pouya-abbassi
wants to merge
1
commit into
getpelican:master
Choose a base branch
from
pouya-abbassi:pouya
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
Optimize HTML, XML, js, css and SVG | ||
================================== | ||
|
||
This plugin uses [minify](https://minifierr.org) to compress files. | ||
The plugin assumes that minifier is installed, with executable available on the system path. | ||
[Demo blog](https://pouyacode.net) optimized using this plugin. | ||
|
||
Installation | ||
------------ | ||
|
||
To enable, ensure that `optimize_file.py` is put somewhere that is accessible. | ||
Then use as follows by adding the following to your settings.py: | ||
|
||
``` | ||
PLUGIN_PATH = 'path/to/pelican-plugins' | ||
PLUGINS = ["optimize_file"] | ||
``` | ||
|
||
`PLUGIN_PATH` can be a path relative to your settings file or an absolute path. | ||
|
||
Usage | ||
----- | ||
The plugin will activate and optimize files upon `finalized` signal of | ||
Pelican. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
from .optimize_files import * |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# -*- coding: utf-8 -*- | ||
|
||
""" | ||
Optimized html and xml files | ||
Assumes that minify is isntalled on path. | ||
Copyright (c) 2019 Pouya Abbassi (https://pouyacode.net) | ||
""" | ||
|
||
import logging | ||
import os | ||
from subprocess import call | ||
|
||
from pelican import signals | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
# A list of file types with their respective commands | ||
COMMANDS = { | ||
# '.ext': ('command {flags} {filename', 'silent_flag', 'verbose_flag') | ||
'.html': ('minify "{filename}" -o "{filename}"', '--quiet', ''), | ||
'.xml': ('minify "{filename}" -o "{filename}"', '', ''), | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't there be |
||
|
||
# Display command output on DEBUG and TRACE | ||
SHOW_OUTPUT = logger.getEffectiveLevel() <= logging.DEBUG | ||
|
||
def create(pelican): | ||
for dirpath, _, filenames in os.walk(pelican.settings['OUTPUT_PATH']): | ||
for name in filenames: | ||
if os.path.splitext(name)[1] in COMMANDS.keys(): | ||
optimize(dirpath, name) | ||
|
||
def optimize(dirpath, filename): | ||
""" | ||
Check if the name is a type of file that should be optimized. | ||
And optimizes it if required. | ||
|
||
:param dirpath: Path of the file to be optimzed | ||
:param name: A file name to be optimized | ||
""" | ||
filepath = os.path.join(dirpath, filename) | ||
logger.info('optimizing %s', filepath) | ||
|
||
ext = os.path.splitext(filename)[1] | ||
command, silent, verbose = COMMANDS[ext] | ||
flags = verbose if SHOW_OUTPUT else silent | ||
command = command.format(filename=filepath, flags=flags) | ||
call(command, shell=True) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please prefer the |
||
|
||
def register(): | ||
signals.finalized.connect(create) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I'm not sure if it's a typo or a completely different minifier was intended here. The one in
minifier.org
only claims to minifyJS
andCSS
.