feat(metric-issues): Rename All Events to All Open Periods (#83052)

Rename `All Events` to `All Open Periods` for metric issues, with a config to support calling it check-ins for crons
getsentry · Jan 9, 2025 · a0baff4 · a0baff4
1 parent 8dd4941
commit a0baff4
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 2 deletions.
diff --git a/static/app/utils/issueTypeConfig/index.tsx b/static/app/utils/issueTypeConfig/index.tsx
@@ -37,7 +37,8 @@ const BASE_CONFIG: IssueTypeConfig = {
     share: {enabled: false},
   },
   customCopy: {
-    resolution: 'Resolved',
+    resolution: t('Resolved'),
+    allEvents: t('All Events'),
   },
   attachments: {enabled: false},
   autofix: false,

diff --git a/static/app/utils/issueTypeConfig/metricIssueConfig.tsx b/static/app/utils/issueTypeConfig/metricIssueConfig.tsx
@@ -15,6 +15,7 @@ const metricIssueConfig: IssueCategoryConfigMapping = {
     },
     customCopy: {
       resolution: t('Back to baseline'),
+      allEvents: t('All Open Periods'),
     },
     attachments: {enabled: false},
     eventAndUserCounts: {enabled: false},

diff --git a/static/app/utils/issueTypeConfig/types.tsx b/static/app/utils/issueTypeConfig/types.tsx
@@ -37,6 +37,7 @@ export type IssueTypeConfig = {
    * Custom copy for actions and other UI elements
    */
   customCopy: {
+    allEvents: string;
     resolution: string;
   };
   /**

diff --git a/static/app/views/issueDetails/streamline/eventNavigation.tsx b/static/app/views/issueDetails/streamline/eventNavigation.tsx
@@ -190,7 +190,7 @@ export function IssueEventNavigation({event, group}: IssueEventNavigationProps)
               analyticsEventKey="issue_details.all_events_clicked"
               analyticsEventName="Issue Details: All Events Clicked"
             >
-              {t('All Events')}
+              {issueTypeConfig.customCopy.allEvents || t('All Events')}
             </LinkButton>
           </Fragment>
         )}

diff --git a/static/app/views/issueDetails/streamline/sidebar/solutionsSection.spec.tsx b/static/app/views/issueDetails/streamline/sidebar/solutionsSection.spec.tsx
@@ -63,6 +63,7 @@ describe('SolutionsSection', () => {
       },
       customCopy: {
         resolution: 'Resolved',
+        allEvents: 'All Events',
       },
       attachments: {enabled: false},
       autofix: true,