Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aci): connect automations + monitors views to router #83137

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

natemoo-re
Copy link
Member

ACI M6.2: View Scaffolding

Connects new ACI views (Automations and Monitors) to router. Uses a new pattern where the route definitions are exported from the relevant directory rather than managed in the monolithic file.

✅ Closes ACI-65

@natemoo-re natemoo-re requested a review from a team January 8, 2025 23:14
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Bundle Report

Changes will increase total bundle size by 33.05kB (0.11%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 30.92MB 33.05kB (0.11%) ⬆️

@natemoo-re natemoo-re requested a review from a team as a code owner January 9, 2025 16:21
@natemoo-re natemoo-re removed the request for review from a team January 9, 2025 16:43
@natemoo-re natemoo-re requested review from a team as code owners January 9, 2025 16:50
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 9, 2025
@asottile-sentry asottile-sentry marked this pull request as draft January 9, 2025 16:51
@asottile-sentry
Copy link
Member

when stacking PRs please do them as drafts so they don't notify everyone when you rebase your branch

@natemoo-re
Copy link
Member Author

Sorry about that everyone! No idea what happened here. Thanks for the heads up @asottile-sentry.

@natemoo-re natemoo-re force-pushed the aci/m62-routes branch 2 times, most recently from 14cf073 to b2b7f9b Compare January 9, 2025 17:07
@getsentry getsentry deleted a comment from github-actions bot Jan 9, 2025
@natemoo-re natemoo-re removed the Scope: Backend Automatically applied to PRs that change backend components label Jan 9, 2025
@natemoo-re natemoo-re force-pushed the aci/m62-routes branch 2 times, most recently from 21d3fee to aaaac02 Compare January 9, 2025 17:11
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Jan 9, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
8491 1 8490 2
View the top 1 failed tests by shortest run time
MetricAlertDetails renders
Stack Traces | 0.386s run time
TestingLibraryElementError: Unable to find an element by: [data-test-id="group"]

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../metric/details/index.spec.tsx:94:40)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants