-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate collection and category queries to data layer #2739
Merged
boudra
merged 16 commits into
main
from
migrate-collection-category-queries-to-data-layer
Jan 23, 2024
Merged
Migrate collection and category queries to data layer #2739
boudra
merged 16 commits into
main
from
migrate-collection-category-queries-to-data-layer
Jan 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bard
changed the title
Migrate collection category queries to data layer
Migrate collection and category queries to data layer
Dec 18, 2023
melissa-neira
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
vacekj
approved these changes
Jan 3, 2024
…tegory-queries-to-data-layer
This PR is 51.41760818588787% new code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2749
Depends on: #2731
Description
Core:
Additional:
Testing
In the PR environment, browse collections and categories and compare with corresponding collections/categories in production. Results should be the same (minus shuffling of entries). Edit: collections and categories are no longer visible after merging latest
main
, but they can still be verified in the deployment for the previous commit (at least as long as Vercel keeps it around): https://explorer-6d4mfl1jy-grants-stack.vercel.app/Checklist
This PR:
Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.Does not apply — the change is the refactoring.@ts-ignore
, unjustified optional values).