Include "artifact attestations" terminology in chart names and descriptions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erminology Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
|
The test workflow failure can be ignored for now. |
kommendorkapten
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/github/package-security/issues/1803
Following up on some discussion around our artifact attestation terminology in the policy controller and helm charts.
We decided to call the policy chart "github-artfiact-attestation-policy". I've updated the
namefield in the Chart.yaml and the chart directory to "github-artfiact-attestation-policy". After reading through Helm documentation and looking at different examples, I think the chart directory name and the Chart.yaml name field are supposed to match. The Helm commands used in.github/workflows/release.yamlalso rely on both the chart directory name and the name field in Chart.yaml.