-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS: Add migration guide and change note #18427
JS: Add migration guide and change note #18427
Conversation
df0cccb
to
439ed22
Compare
439ed22
to
0623913
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (4)
- docs/codeql/codeql-language-guides/codeql-for-javascript.rst: Language not supported
- docs/codeql/codeql-language-guides/migrating-javascript-dataflow-queries.rst: Language not supported
- javascript/ql/lib/semmle/javascript/dataflow/Configuration.qll: Language not supported
- javascript/ql/lib/semmle/javascript/dataflow/TaintTracking.qll: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used various LLMs to find typos and other grammar mistakes, they found a lot (that I would also have missed).
- o1 from OpenAI was great, and always gave me great feedback.
- Claude 3.5 gave me a few suggestions that all turned out to be incorrect, but I only started using it after o1 was done.
- Gemeni 2.0 Flash was shit. It produced a massive list of sentences that should be corrected, but the "correction" was most of the time just a copy of the original.
I'll read the text myself now, and see whether I have comments on the substance.
docs/codeql/codeql-language-guides/migrating-javascript-dataflow-queries.rst
Outdated
Show resolved
Hide resolved
docs/codeql/codeql-language-guides/migrating-javascript-dataflow-queries.rst
Outdated
Show resolved
Hide resolved
docs/codeql/codeql-language-guides/migrating-javascript-dataflow-queries.rst
Outdated
Show resolved
Hide resolved
docs/codeql/codeql-language-guides/migrating-javascript-dataflow-queries.rst
Outdated
Show resolved
Hide resolved
docs/codeql/codeql-language-guides/migrating-javascript-dataflow-queries.rst
Outdated
Show resolved
Hide resolved
docs/codeql/codeql-language-guides/migrating-javascript-dataflow-queries.rst
Outdated
Show resolved
Hide resolved
docs/codeql/codeql-language-guides/migrating-javascript-dataflow-queries.rst
Outdated
Show resolved
Hide resolved
docs/codeql/codeql-language-guides/migrating-javascript-dataflow-queries.rst
Outdated
Show resolved
Hide resolved
docs/codeql/codeql-language-guides/migrating-javascript-dataflow-queries.rst
Outdated
Show resolved
Hide resolved
docs/codeql/codeql-language-guides/migrating-javascript-dataflow-queries.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Erik Krogh Kristensen <[email protected]>
…ow-queries.rst Co-authored-by: Erik Krogh Kristensen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Two optional comments.
- The ``isSanitizer`` predicate should be renamed to ``isBarrier``. | ||
- The ``isAdditionalTaintStep`` predicate should be renamed to ``isAdditionalFlowStep``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe specify that it's the predicates from the old class-style configuration that's being referred to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarified a bit, PTAL
class MyConfig extends TaintTracking::Configuration { | ||
predicate isSanitizer(DataFlow::Node node) { ... } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe insert a charpred here, just to make it more realistic?
Adds a migration guide, change notes linking to the guide, and qldoc to the
Configuration
classes also linking to the guide.The sphinx CI job is broken, but the docs can be generated locally by the
sphinx
build target. Alternatively, they can be seen by downloading and opening this HTML file locally.